Use single LR/SC flag per tile.#53
Open
fei-g wants to merge 1 commit intoPrincetonUniversity:openpiton-devfrom
Open
Use single LR/SC flag per tile.#53fei-g wants to merge 1 commit intoPrincetonUniversity:openpiton-devfrom
fei-g wants to merge 1 commit intoPrincetonUniversity:openpiton-devfrom
Conversation
…a flag per cacheline. Passed the lrsc_test.c
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of having a flag per cacheline, change to use a single lrsc flag per tile in L1.5. Passed the lrsc_test.c.
In this case, we only support one outstanding LR/SC transaction per tile.
Example:
LR addr1;
LR addr2; // overwrite the state of the first LR
SC addr2; // succeed
SC addr1; // fail
We also need to make sure that different threads in one tile will not LR/SC at the same address at the same time.