feat(docker): add container health checks#462
Open
devEunicee wants to merge 1 commit into
Open
Conversation
- Add HEALTHCHECK to Dockerfile using STELLAR_RPC_URL/health endpoint (interval 30s, timeout 10s, start-period 15s, retries 3) - Add healthcheck to stellar-node service in docker-compose.yml (interval 15s, timeout 10s, start-period 30s, retries 5) - Add healthcheck to dev service; make it depend on stellar-node being healthy before starting (condition: service_healthy) - Document container health semantics in docs/GETTING_STARTED.md Closes PrincessnJoy#289
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #289
Docker containers now expose health status so orchestration tools (Docker Swarm, Kubernetes, CI pipelines) can determine service readiness before routing traffic or running dependent jobs.
Changes
DockerfileHEALTHCHECKinstruction polling${STELLAR_RPC_URL:-http://localhost:8000}/healthevery 30 s (timeout 10 s, start-period 15 s, retries 3)docker-compose.ymlstellar-node: addedhealthcheckonhttp://localhost:8000/health(interval 15 s, start-period 30 s to allow node init, retries 5)dev: addedhealthcheckonhttp://stellar-node:8000/health; changeddepends_ontocondition: service_healthyso the build container only starts after the node is readydocs/GETTING_STARTED.md