feat(scripts): add testnet deploy script and CI validation#441
Merged
PrincessnJoy merged 2 commits intoJun 27, 2026
Merged
Conversation
…Joy#324) - Add scripts/deploy_testnet.sh: testnet-specific deploy script with DRY_RUN=1 mode that validates all required inputs without network calls - Add .github/workflows/deploy-validation.yml: CI that runs shellcheck on deploy_testnet.sh and deploy_mainnet.sh, plus dry-run execution of deploy_testnet.sh and bash -n syntax check of deploy_mainnet.sh - Add docs/deployment.md: required inputs table, dry-run instructions, and CI validation documentation Closes PrincessnJoy#324
|
@ladinoraa Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #324
Deployment scripts had no CI validation, meaning broken scripts could be merged silently. This PR adds a dedicated testnet script with built-in dry-run validation, a CI workflow that checks both scripts on every PR, and documentation for all required inputs.
Changes
scripts/deploy_testnet.sh(new)DRY_RUN=1mode: validates all required inputs without making any network callsRESTRICT_ADMIN_VOTEistrueorfalseSTELLAR_SECRET_KEYmatches Stellar secret key format (S[A-Z2-7]{55}).github/workflows/deploy-validation.yml(new)Three jobs triggered on any PR touching deploy scripts:
-S warningseveritydeploy_testnet.shwithDRY_RUN=1and stub keybash -nsyntax check (no execution; mainnet script is interactive)docs/deployment.md(new)Testing
The dry-run mode was validated locally with valid and invalid inputs covering each validation path.