Refactor hookActionCustomerAccountAdd in ps_emailsubscription by Codencode · Pull Request #121 · PrestaShop/ps_emailsubscription

Codencode · 2025-12-07T11:35:54Z

Questions	Answers
Description?	This PR simplifies the `hookActionCustomerAccountAdd` logic by acting only on valid emails and newsletter-subscribed customers, removing unnecessary and unreachable code. Related: #114 (comment)
Type?	refacto
BC breaks?	no
Deprecations?	no
Fixed ticket?
How to test?

Touxten · 2026-01-21T09:36:05Z

+                $this->sendVoucher($email, $code);
            }
+
+            return (bool) Db::getInstance()->execute('DELETE FROM ' . _DB_PREFIX_ . 'emailsubscription WHERE id_shop=' . (int) $id_shop . ' AND email=\'' . pSQL($email) . "'");


Suggested change

return (bool) Db::getInstance()->execute('DELETE FROM ' . _DB_PREFIX_ . 'emailsubscription WHERE id_shop=' . (int) $id_shop . ' AND email=\'' . pSQL($email) . "'");

return Db::getInstance()->execute('DELETE FROM `' . _DB_PREFIX_ . 'emailsubscription` WHERE id_shop = ' . (int) $id_shop . 'AND email = "' . pSQL($email) . '"');

Or only ' with slash ' ?

@Touxten, I based it on the previous code, but if you think it's better this way, I'll make the change.

Yes, I saw that. What's causing me trouble is the mix of ' / ” at the end of the query.

I've validated the PR. I'll leave it up to you to choose :D Nice job !

@Touxten I made the change you suggested, it does look better stylistically :-)
Thanks!

Touxten · 2026-02-28T08:36:35Z

I'm going to do a PR to correct the tests.

Touxten · 2026-02-28T14:05:08Z

#123

Codencode · 2026-03-02T14:57:22Z

@Touxten your PR worked perfectly!

Thanks!

Codencode · 2026-03-03T10:36:42Z

ping @kpodemski

paulnoelcholot

Hello @Codencode,

I tested your PR and I found some bug :

PR-2026-03-26_10.57.47.mp4

I have the problem when Double opt-in are activated or desactivated. And only for an account creation. I don't have this problem when I want to subscribe to the newsletter without creating an account.

Can you check that please?

Thanks!

Codencode · 2026-04-09T20:18:30Z

Ping @Touxten @kpodemski

Codencode · 2026-05-26T14:47:57Z

@Touxten @kpodemski could you re-approve the PR with this fix in place?

Touxten · 2026-08-28T08:39:07Z

Tests performed

Scenario 1 — Account created without newsletter subscription

Subscribe to the newsletter without creating a customer account.
Check that the email address exists in the ps_emailsubscription table.
Create a customer account using the same email address.
Do not select the newsletter checkbox.

Result: ✅ The customer remains subscribed, and the email address is still present in the ps_emailsubscription table.

test-pr-email.mp4

Scenario 2 — Account created with newsletter subscription

Subscribe to the newsletter without creating a customer account.
Check that the email address exists in the ps_emailsubscription table.
Create a customer account using the same email address.
Select the newsletter checkbox.

Result: ✅ The customer is subscribed through their customer account, and the email address is correctly removed from the ps_emailsubscription table.

test-pr-email-2.mp4

@kpodemski and @Codencode Is this really what I was supposed to test?

Touxten · 2026-08-28T08:40:01Z

I wait before merge

Codencode · 2026-08-28T09:11:24Z

@Touxten
Thanks for the QA!

While preparing the How to test, I noticed that when a customer creates an account and subscribes to the newsletter, the method returns before reaching sendConfirmationEmail(). This means that even if NW_CONFIRMATION_EMAIL is enabled, the newsletter confirmation email is not sent in this case.

This behavior already exists today, so the PR does not introduce it, but I’d like to confirm whether it is actually expected.

If the email should be sent, I could update this PR to handle it, or would it be better to create a separate PR for that change?

@kpodemski, what do you think?

kpodemski · 2026-08-28T20:54:06Z

@Codencode

If the confirmation is required, then the email should be sent. My understanding is that this person shouldn't be considered as an active subscriber for as long as they haven't confirmed their subscription, correct?

Codencode · 2026-08-29T07:28:54Z

@kpodemski I was initially referring specifically to NW_CONFIRMATION_EMAIL and sendConfirmationEmail().

However, looking deeper into this, I found PrestaShop/PrestaShop#17097, which describes a broader issue with account creation: when a customer creates an account and subscribes to the newsletter, neither the verification email nor the confirmation email is sent, and the customer is immediately considered subscribed.

So I think there are actually two related cases here:

NW_CONFIRMATION_EMAIL: the confirmation email is currently never reached during account creation.
NW_VERIFICATION_EMAIL: if double opt-in is enabled, the customer should probably not be considered an active subscriber until the subscription is verified.

In my opinion, it would be better to merge this PR as it is and then open a separate PR to address both issues properly: sending the confirmation email and handling the verification email flow during account creation.

What do you think?

Touxten · 2026-08-29T07:39:26Z

I agree—in any case, it has nothing to do with this PR; we'd have to create another one.

Codencode · 2026-08-29T10:17:01Z

Yes, I think so too. Let's wait for confirmation from @kpodemski, after which we can merge it and I'll create a separate PR.

Actually, it's almost ready, so as soon as we merge this one I'll publish it so we can verify and merge it in a way that the new module release will also include the new fixes.

kpodemski · 2026-08-29T11:27:35Z

This one is not related to my comment, merged 👍🏻 thanks guys

Codencode · 2026-08-29T12:27:32Z

New PR: #139

Codencode requested a review from kpodemski December 7, 2025 11:35

ps-jarvis added this to PR Dashboard Dec 7, 2025

github-project-automation Bot moved this to Ready for review in PR Dashboard Dec 7, 2025

Codencode mentioned this pull request Dec 7, 2025

Fix: Problem with the newsletter subscription module #114

Merged

Codencode requested a review from a team January 21, 2026 08:47

Touxten previously approved these changes Jan 21, 2026

View reviewed changes

Codencode dismissed Touxten’s stale review via 3756e51 January 21, 2026 11:49

Touxten previously approved these changes Jan 21, 2026

View reviewed changes

Codencode requested a review from a team February 27, 2026 20:14

Touxten closed this Feb 28, 2026

github-project-automation Bot moved this from Ready for review to Closed in PR Dashboard Feb 28, 2026

Touxten reopened this Feb 28, 2026

ps-jarvis moved this from Closed to Ready for review in PR Dashboard Feb 28, 2026

github-project-automation Bot moved this from Ready for review to Reopened in PR Dashboard Feb 28, 2026

Codencode added 2 commits March 2, 2026 15:23

Refactor hookActionCustomerAccountAdd in ps_emailsubscription

43e2b95

refactor: improve emailsubscription DELETE query formatting

b4ba7f6

Codencode force-pushed the refactor/email-subscription-cleanup-hook branch from 3756e51 to b4ba7f6 Compare March 2, 2026 14:23

kpodemski previously approved these changes Mar 25, 2026

View reviewed changes

ps-jarvis added the Waiting for QA label Mar 25, 2026

ps-jarvis moved this from Reopened to To be tested in PR Dashboard Mar 25, 2026

kpodemski added Waiting for QA by Community Status: Action required, Waiting for test feedback by Community Waiting for QA and removed Waiting for QA Waiting for QA by Community Status: Action required, Waiting for test feedback by Community labels Mar 25, 2026

paulnoelcholot self-assigned this Mar 26, 2026

paulnoelcholot reviewed Mar 26, 2026

View reviewed changes

Codencode requested a review from kpodemski March 26, 2026 20:42

Codencode removed the waiting for author label Mar 26, 2026

Codencode added this to the 2.8.4 milestone May 26, 2026

Codencode added the Waiting for QA by Community Status: Action required, Waiting for test feedback by Community label Jun 20, 2026

kpodemski approved these changes Jul 2, 2026

View reviewed changes

mattgoud modified the milestones: 2.8.4, 3.0.1 Jul 2, 2026

Codencode requested a review from paulnoelcholot July 9, 2026 12:15

Touxten added QA ✔️ Status: Check done, Code approved and removed Waiting for QA by Community Status: Action required, Waiting for test feedback by Community Waiting for QA labels Aug 28, 2026

Touxten assigned Touxten and unassigned paulnoelcholot Aug 28, 2026

Touxten mentioned this pull request Aug 28, 2026

Fix newsletter subscription cleanup on customer update #136

Merged

kpodemski merged commit 1d577e6 into PrestaShop:dev Aug 29, 2026
14 checks passed

github-project-automation Bot moved this from To be tested to Merged in PR Dashboard Aug 29, 2026

Codencode deleted the refactor/email-subscription-cleanup-hook branch August 29, 2026 12:16

Codencode mentioned this pull request Aug 29, 2026

Fix newsletter verification and confirmation during account registration #139

Open

boo-code mentioned this pull request Aug 31, 2026

Newsletter Verification Mail & Confirmation email when creating a new customer are not sent PrestaShop/PrestaShop#17097

Open

	return (bool) Db::getInstance()->execute('DELETE FROM ' . _DB_PREFIX_ . 'emailsubscription WHERE id_shop=' . (int) $id_shop . ' AND email=\'' . pSQL($email) . "'");
	return Db::getInstance()->execute('DELETE FROM `' . _DB_PREFIX_ . 'emailsubscription` WHERE id_shop = ' . (int) $id_shop . 'AND email = "' . pSQL($email) . '"');

Uh oh!

Conversation

Codencode commented Dec 7, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Touxten Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Touxten Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Codencode Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Touxten Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Codencode Jan 21, 2026

Choose a reason for hiding this comment

Uh oh!

Touxten commented Feb 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Touxten commented Feb 28, 2026

Uh oh!

Codencode commented Mar 2, 2026

Uh oh!

Codencode commented Mar 3, 2026

Uh oh!

paulnoelcholot left a comment

Choose a reason for hiding this comment

Uh oh!

Codencode commented Apr 9, 2026

Uh oh!

Codencode commented May 26, 2026

Uh oh!

Touxten commented Aug 28, 2026

Tests performed

Scenario 1 — Account created without newsletter subscription

Scenario 2 — Account created with newsletter subscription

Uh oh!

Touxten commented Aug 28, 2026

Uh oh!

Codencode commented Aug 28, 2026

Uh oh!

kpodemski commented Aug 28, 2026

Uh oh!

Codencode commented Aug 29, 2026

Uh oh!

Touxten commented Aug 29, 2026

Uh oh!

Codencode commented Aug 29, 2026

Uh oh!

Uh oh!

kpodemski commented Aug 29, 2026

Uh oh!

Codencode commented Aug 29, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

Codencode commented Dec 7, 2025 •

edited

Loading

Touxten Jan 21, 2026 •

edited

Loading

Touxten commented Feb 28, 2026 •

edited

Loading