Conversation
|
The soft delete is very interesting 👍, let's understand how to manage on legal side tho |
I missed to delete all customer data. But once this is fixed, there should not remain any legal problem. Don't you think ? |
|
Waiting for you @lmeyer1 😉 |
|
This PR is blocking 2.4.2 release. |
|
@lmeyer1 can you rebase maybe on the latest version of the dev branch to avoid merge worries ? |
|
For information, the install function has a bug preventing database creation: missing coma at the end of line 139 |
|
@LouisAUTHIE I hope the rebase was successful. |
github-project-automation
Bot
moved this from Ready for review
to Closed
in PR Dashboard
|
|
||
| /** @var string Object last modification date */ | ||
| public $date_upd; | ||
|
|
There was a problem hiding this comment.
notification_sent and deleted are missing I guess
| 'id_shop' => ['type' => self::TYPE_INT, 'validate' => 'isUnsignedInt', 'required' => true], | ||
| 'id_lang' => ['type' => self::TYPE_INT, 'validate' => 'isUnsignedInt', 'required' => true], | ||
| 'date_add' => ['type' => self::TYPE_DATE, 'validate' => 'isDate'], | ||
| 'date_upd' => ['type' => self::TYPE_DATE, 'validate' => 'isDate'], |
There was a problem hiding this comment.
notification_sent and deleted are missing I guess
| function upgrade_module_2_3_4() | ||
| { | ||
| $result = Db::getInstance()->execute('ALTER TABLE `' . _DB_PREFIX_ . 'mailalert_customer_oos` ADD `date_add` DATETIME NOT NULL, ADD `date_upd` DATETIME NOT NULL;'); | ||
| $result = $result && Db::getInstance()->execute('ALTER TABLE `' . _DB_PREFIX_ . 'mailalert_customer_oos` ADD `deleted` TINYINT NOT NULL DEFAULT 0, ADD `notification_sent` DATETIME NULL DEFAULT NULL, ADD INDEX (`deleted`)'); |
There was a problem hiding this comment.
this two lines could be in one
9 participants
ps_mailalert_customer_oos, in order for merchant to be able to analyze customer needs and behavior.There are these improvements in the db:
date_addnotification_sentand the line is soft-deleted.