Add SQL request settings endpoint - #280
Closed
PrestaEdit wants to merge 2 commits into
Closed
PrestaEdit wants to merge 2 commits into
PrestaEdit wants to merge 2 commits into
Conversation
PUT /sql-request-settings (SaveSqlRequestSettingsCommand) sets the SQL manager export file encoding (utf-8 / iso-8859-1) and separator. A singleton resource. The integration test updates the settings and verifies them via Configuration. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The handler maps the charset to an int (utf-8 => 1, iso-8859-1 => 2), so assert the integer value. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
Author
|
Superseded by #415, which merges this endpoint with the rest of the domain, following the mutualisation asked for by the core team (one PR per domain rather than one per endpoint). The consolidated PR is green and lists what changed for this endpoint on the way in. Closing here to keep the review in one place. |
github-project-automation
Bot
moved this from Ready for review
to Closed
in PR Dashboard
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
PUT /sql-request-settings—SaveSqlRequestSettingsCommand: sets the SQL manager exportfile encoding (
utf-8/iso-8859-1) and separator (204). A singleton resource.The integration test updates the settings and verifies them through
Configuration. Reuses thesql_management_writescope.