Add Customer private-note endpoint - #218
Closed
PrestaEdit wants to merge 1 commit into
Closed
PrestaEdit wants to merge 1 commit into
PrestaEdit wants to merge 1 commit into
Conversation
Expose SetPrivateNoteAboutCustomerCommand through
PATCH /customers/{customerId}/private-note, in a dedicated resource class so
the rich Customer resource is left untouched. The body carries the privateNote
string (mapped by matching field name).
Adds an integration test and a scopes entry.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
PrestaEdit
force-pushed
the
add-customer-private-note-endpoint
branch
from
June 11, 2026 07:42
530cdff to
844fca8
Compare
PrestaEdit
marked this pull request as draft
August 20, 2026 08:23
Contributor
Author
|
Superseded by #428, which merges this endpoint with the rest of the domain, following the mutualisation asked for by the core team (one PR per domain rather than one per endpoint). The consolidated PR is green and lists what changed for this endpoint on the way in. Closing here to keep the review in one place. |
github-project-automation
Bot
moved this from Ready for review
to Closed
in PR Dashboard
mattgoud
pushed a commit
to PrestaEdit/ps_apiresources
that referenced
this pull request
Sep 23, 2026
Consolidates PrestaShop#218, PrestaShop#225, PrestaShop#243 and PrestaShop#342. PrestaShop#218 and PrestaShop#225 both wrote CustomerEndpointTest.php and conflict on cherry-pick, which is the usual sign that they belonged in one PR. PrestaShop#342 is dropped rather than merged. It exposed GetCustomerForAddressCreation as GET /customers/address-creation-infos?customerEmail=, but that query is already listed in EXCLUDED_CQRS_CLASSES on dev with the USELESS_DUPLICATE reason — and the exclusion is right: GET /customers/search matches on email among other fields and returns idCustomer, firstname, lastname and company, a strict superset of the four fields the dropped endpoint returned. The exclusion entry already exists, so this PR adds nothing for it. The private-note test now asserts its work: the note is the privateNote of the generalInformation of GET /customers/{customerId}/details, so the write finally has a read side to check against. It previously asserted the 204 and nothing else. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exposes
SetPrivateNoteAboutCustomerCommandthroughPATCH /customers/{customerId}/private-notes, in a dedicated resource class so therich
Customerresource is left untouched. The body carries theprivateNotestring(mapped by matching field name). The URI uses the plural
private-notesto satisfy themodule's
ApiResourceUriTemplateRectorconvention.Adds an integration test and a scopes (authorization) entry.