fix: prevent privilege escalation in set-role endpoint (#3954)#3959
Open
atul-upadhyay-7 wants to merge 10 commits into
Open
fix: prevent privilege escalation in set-role endpoint (#3954)#3959atul-upadhyay-7 wants to merge 10 commits into
atul-upadhyay-7 wants to merge 10 commits into
Conversation
- Add admin invite code validation (requires ADMIN_INVITE_CODE env var) - Add role hierarchy check to prevent escalation from lower roles - Validate all role values (reject unknown roles) Fixes Premshaw23#3954
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the privilege escalation vulnerability in the endpoint that allowed any authenticated user to self-appoint as admin without any invite code or approval.
Changes
Added admin invite code validation — The role now requires a valid environment variable, matching the existing pattern for and roles.
Added role hierarchy check — Prevents users with existing roles from escalating to a higher-privilege role (e.g., a cannot upgrade themselves to ).
Added role validation — Unknown roles are now rejected with a 403 error instead of being silently accepted.
How It Works
Testing
Related Issue
Fixes #3954