Fix/issue 3931 progress bar jitter#3941
Open
pradeep0153 wants to merge 9 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3931.
Description
This PR fixes a highly distracting visual glitch where the global "Course Completion %" circular progress bar in the main navigation header would rapidly flicker back and forth when a student manually skipped ahead on a video timeline.
Changes Made
timeupdateevent handler inside the video player that calculates the percentage watched and emits state updates to the global Redux store.currentTimeand dividing it byduration. When a user clicked ahead, unbuffered and unwatched segments of the video temporarily confused the browser's internal timer, causingcurrentTimeto rapidly fluctuate wildly for a few milliseconds while it buffered.currentTimeproperty during active seeking.Impact