Skip to content

test: restore the dividend distribution self-claim step #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
prashantasdeveloper wants to merge 1 commit into
base: main
Choose a base branch
from
+22 −13
Open

test: restore the dividend distribution self-claim step #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 22 additions & 13 deletions tests/src/__tests__/rest/corporate-actions/dividend-distributions.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { createAssetParams } from '~/rest/assets/params';
import { createCheckpointParams } from '~/rest/checkpoints/params';
import { ProcessMode } from '~/rest/common';
import {
claimDividendDistributionParams,
createDividendDistributionParams,
modifyDistributionCheckpointParams,
payDividendDistributionParams,
Expand Down Expand Up @@ -213,18 +214,26 @@ describe('Dividend Distributions', () => {
expect(distributions.results[0].id).toBe(distributionId);
});

// NOTE: a "claimant self-claims via `capitalDistribution.claim`" step was removed here.
// It consistently rejects with "The signing Identity is not included in this Distribution"
// (the SDK's DividendDistribution.getParticipant() returns null), even though:
// - claimant's checkpoint-time balance is confirmed correct (see the diagnostic assertion
// in "should create a dividend distribution", which checks the same checkpoint directly)
// - targets uses the default Exclude:[] (everyone included), so target-list membership
// isn't the issue
// - the equivalent push-based payment (to the holder, above) succeeds against the same
// distribution/checkpoint
// This looks like a genuine discrepancy between getParticipant()'s internal checkpoint-balance
// resolution and the identical query made directly through the checkpoint-balances endpoint,
// rather than anything wrong with these params. Needs SDK-level investigation to pin down.
it('claimant should be able to claim the distribution', async () => {
const params = claimDividendDistributionParams({
options: { processMode: ProcessMode.Submit, signer: claimant.signer },
});

const result = await restClient.corporateActions.claimDividendDistribution(
assetId,
distributionId,
params
);
expect(result).toMatchObject({
transactions: expect.arrayContaining([
{
transactionTag: 'capitalDistribution.claim',
type: 'single',
...expectBasicTxInfo,
},
]),
});
});

it('should reclaim the distribution', async () => {
const remainingMs = expiryDate.getTime() - Date.now();
Expand Down Expand Up @@ -252,7 +261,7 @@ describe('Dividend Distributions', () => {
});

it('should be able to get payment history', async () => {
// only the holder was actually paid (pushed); the claimant's claim step above is skipped
// the holder was paid via a push; the claimant claimed their own share above
const result = await restClient.corporateActions.paymentHistory(assetId, distributionId);
expect(result).toMatchObject({
results: expect.arrayContaining([
Expand Down
Loading