Add more integration tests and some AGENTS files. - #1996
Open
Neopallium wants to merge 5 commits into
Open
Conversation
Neopallium
force-pushed
the
add_more_integration_tests
branch
from
August 25, 2026 14:33
9671b95 to
90aaec8
Compare
Neopallium
force-pushed
the
add_more_integration_tests
branch
from
August 25, 2026 17:46
90aaec8 to
cd0ec42
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a broad set of new RPC-based integration tests across multiple pallets/features, plus new “AGENTS.md” operational guidance and CI wiring to run time-dependent tests via a new timed feature.
Changes:
- Added many new integration test binaries covering settlement, compliance/statistics enforcement, relayer negative paths, STO controls, asset/NFT/portfolio/identity lifecycle, corporate actions/ballots, checkpoints, and economics.
- Introduced shared helper extractors and utilities (
get_checkpoint_id,unique_symbol, etc.) to support the new tests. - Updated CI + integration workspace features/docs to run timed tests (
current_release,timed) and document how to run/write tests.
Reviewed changes
Copilot reviewed 24 out of 24 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| integration/tests/utility_calls.rs | Adds Utility pallet tests for force_batch/batch_all and as_derivative. |
| integration/tests/sto.rs | Adds extended STO tests for freeze/unfreeze/window modification/stop. |
| integration/tests/statistics_enforcement.rs | Adds investor-count enforcement/exemption/stat update tests. |
| integration/tests/settlement_venues.rs | Adds venue CRUD/signers and per-asset venue filtering tests. |
| integration/tests/settlement_scheduling.rs | Adds timed tests for scheduled/automatic settlement execution and atomic failure behavior. |
| integration/tests/settlement_mediators.rs | Adds mediator flows: affirm, reject, lock/unlock. |
| integration/tests/revive_erc3643.rs | Makes ERC3643 symbol-setting test use a unique symbol to avoid collisions. |
| integration/tests/relayer_negative.rs | Adds negative-path relayer/subsidy tests (expiry, replay, limits, revoke/remove). |
| integration/tests/portfolio_custody.rs | Adds custody portfolio lifecycle, permissions, pre-approvals, rename/delete tests. |
| integration/tests/nft.rs | Adds NFT collection/issue/transfer/controller-transfer/redeem coverage. |
| integration/tests/identity_lifecycle.rs | Adds identity lifecycle tests (PK rotation, SK freeze/remove, claims, auth flows). |
| integration/tests/economics.rs | Adds protocol-fee and treasury reimbursement/disbursement tests (includes a sudo fee mutation). |
| integration/tests/corporate_ballot.rs | Adds ballot attach/vote and admin updates coverage. |
| integration/tests/compliance_enforcement.rs | Adds end-to-end compliance enforcement tests (claims, expiry, pause/resume, requirement changes). |
| integration/tests/checkpoints.rs | Adds manual/scheduled checkpoint and invalid schedule tests. |
| integration/tests/capital_distribution.rs | Adds capital distribution distribute/claim and timed push/reclaim coverage. |
| integration/tests/ca_extended.rs | Adds extended corporate action tests (record dates, docs, withholding, targets). |
| integration/tests/asset_controls.rs | Adds asset lifecycle control tests (freeze, redeem, divisibility, rename/type, docs, identifiers, controller transfer). |
| integration/src/lib.rs | Adds new event extractors for checkpoints/distributions/ballots. |
| integration/src/erc20_helper.rs | Adds unique_symbol helper for ERC-related tests. |
| integration/Cargo.toml | Adds timed feature and fixes formatting in dependency feature list. |
| integration/AGENTS.md | Adds detailed integration-test agent guide (how to run/write/triage). |
| AGENTS.md | Adds repo-wide agent guide (build/test/CI notes). |
| .circleci/config.yml | Updates integration-test CI job to run with --features current_release,timed. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog
other