You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Could you explain the point of a disabled text input?
I think it would make more sense to add the desired functionality (selecting, copying) to the label, instead of manually disabling all function that edit its contents (and requiring every future contributor of TextInput to know and apply this check)
Could you explain the point of a disabled text input? I think it would make more sense to add the desired functionality (selecting, copying) to the label, instead of manually disabling all function that edit its contents (and requiring every future contributor of TextInput to know and apply this check)
The reason for having to add a disabled option is to tell the player that the content of the field cannot be edited. When making the edit_world window, I was thinking of showing the seed value as a Label but it didnt look good. The TextInput changes work without changing any previous code.
So it's mainly the visual difference between a label and a text field? So the background color and (optionally) the scrollbar?
Wouldn't it then be more useful to allow vertical/HorizontalLists to overwrite the background color?
Yes, that can be done but It will help us in the long run, I have used a few UI libraries that give us an option to disable the text field, so I think that maybe it is better than changing the background color of of a list.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mistakenly delated the branch previously, so had to create a new pull request.