Update the music to the new format and utilize some of the new songs - #3044
Conversation
|
I will check this out, though not for the purposes of reviewing where the music is placed. Thank you for doing this. |
|
Seems to be all formatted correctly. I will give you a heads-up that the folder name for my music will be changed to simply "ikabod" when PixelGuys/Cubyz-Assets#17 is merged. |
Wait why not? |
|
I felt it unecessary to do so considering the music system will be overhauled at some point, but I realize that there's a pretty high chance that won't be done until much later, so i will go in and see if the music fits. Tomorrow, though :P |
|
My thoughts:
What you should change:
|
|
Oh yeah, and Scoria should play in hot cave biomes such as the basalt caves. |
Fixed! |
|
Okay, now @IntegratedQuantum. Since both PixelGuys/Cubyz-Assets#17 and this PR are fixed, which one will you merge first? I think you should merge mine as it has the new folder name, so it can be fixed in this PR. |
|
Alright, this PR will need to be changed: Hands I, Hands II, and Atlantis are now removed, so please find alternatives to them. |
|
To do so you will need to update the dependency in the build.zig.zon to the new release which will be created in a few minutes |
|
It should be all working now! |
|
Fixed! |
ikabod-kee
left a comment
There was a problem hiding this comment.
Alright, seems good!
|
Got the CI working! |
IntegratedQuantum
left a comment
There was a problem hiding this comment.
Could you also include some of the songs from PixelGuys/Cubyz-Assets#23 particularly fridgid feelings intended for cold biomes, and hypoxia intended for barren biomes (see PixelGuys/Cubyz-Assets#23 (comment))
|
what happened to in the depths? |
Progress towards #1835