Cold Tall Mountain Variant - #3017
Conversation
|
are these taller mountains? |
no, they are about the same height and will replace the current ones |
|
ah |
|
@careeoki if you could take a look at this at some point that would be appreciated. |
|
#3010 should be reviewed first, since this is like a variant of it |
|
Any suggestions for music for this variant, I think that it would be neat if the two different mountain types had two different tracks. |
|
I'll be updating this to include the height changes I've made on the other PR later today. |
|
@careeoki I've updated this PR to match the other one with height and other changes that should be parallel between this and the other one. |
There was a problem hiding this comment.
Alright, I know you're not gonna like what I'm gonna say, but for making snowy biomes like this I think we should wait for #1364
I really do not like how snowy-forest type biomes look when there's snow on the ground but the trees are completely bare. It just looks wrong.
I would be okay with it if there was just significantly less trees here.
There was a problem hiding this comment.
honestly I just put this in because I didn't want to put the tall mountain with trees on a cold mountain without them. I don't really care how many there are. I can change tree count or just switch it to generate on an already in game mountain.
There was a problem hiding this comment.
The tall mountain itself looks fine.
One thing I liked about your temperate tall mountain is how distinct the different layers were. Obviously you don't have as many blocks to work with here, but something simple like having big icicles on the higher slopes, similar to the peak biome, would be cool.
There was a problem hiding this comment.
I added some of the big icicles on the higher slopes, also thought it would be a good idea to add some ones made out of snow.
There was a problem hiding this comment.
Also, I think these biomes should be in cubyz:tall_mountain/cold/ rather than a seperate folder
There was a problem hiding this comment.
You should remove these changes as to not cause conflicts with #3098
|
Also you are failing the format check because you have spaces instead of tabs. |
There was a problem hiding this comment.
Actually, one more thing, please add .pine and .snowy tags here
There was a problem hiding this comment.
Done(I did sync this time)
|
Please put it in a cave! |
IntegratedQuantum
left a comment
IntegratedQuantum
left a comment
There was a problem hiding this comment.
Ok jokes aside here is the actual review:
- the top is a flat on the lower mountains:
- There are ridges (you can use the same fix as for the other mountain
- The mountains are too steep
|
I've fixed the ravine with some keep original terrain and the flat summit should be fixed. The steepness is the same for the other tall mountain so I don't think it should be excluded if the other one got merged. Also there isn't a way to make it much less steep without making it shorter or wider, I've done a lot of experiments. |
|
Is there any reason why we can't make it wider? |
|
ok, it seems the steep one was just an edge case, I checked again and they don't look as steep. |
|
I do however still think the summit looks too flat, and it also doesn't blend well with the surrounding terrain, you can clearly see a cut. |
…ught it was to common
| .parentBiomes = .{ | ||
| .{ | ||
| .id = "cubyz:cold_mountains", | ||
| .chance = 0.55, |
There was a problem hiding this comment.
I'd suggest to set the chance to , in my opinion the base biome isn't all that interesting without the mountain in the center.
| .chance = 0.55, | |
| .chance = 1, |
|
Could you please rebase your PR and check for new errors when launching a game? |
|
Alright hopefully what codemob told me to do was correct. |
5 participants
This is another mountain update, adding a cold variant and splitting up the rather large PR that it was before.