Pass .pic = true to make the code compatible with the thread sanitizier - #18
Merged
Merged
Conversation
IntegratedQuantum
changed the title
.pice = true to make the code compatible with the thread sanitizier.pic = true to make the code compatible with the thread sanitizier
3 tasks
IntegratedQuantum
added a commit
to PixelGuys/Cubyz
that referenced
this pull request
Jul 24, 2026
- [x] Update the Cubyz-libs to include PixelGuys/Cubyz-libs#18 - [x] ~~Force someone else to test it~~ (I couldn't force them, they did so willingly) - [x] fix release failure -> the libs need to be built in release to use release Notes the thread sanitizer does not work on - Windows - Nvidia drivers - Linux Kernel version after kernel 7.1 llvm/llvm-project#194116 fixed in Zig https://codeberg.org/ziglang/zig/commit/c855c61432f484a1e4016366d7d178bb90d3e552 What does it work on then? - It works on my machine :P fixes #3402
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The thread sanitizer seems to require position independent code in all linked libraries.
As far as I can tell there should be no measurable performance difference from enabling this, especially given that none of these libraries are performance sensitive.
Progress towards PixelGuys/Cubyz#3402