Skip to content

Update harfbuzz and freetype - #16

Merged
IntegratedQuantum merged 3 commits into
PixelGuys:masterfrom
AfmanS:harfbuzz
Aug 3, 2026
Merged

Update harfbuzz and freetype#16
IntegratedQuantum merged 3 commits into
PixelGuys:masterfrom
AfmanS:harfbuzz

Conversation

@AfmanS

@AfmanS AfmanS commented May 23, 2026

Copy link
Copy Markdown
Contributor

Tested in Linux x86, name rendering looks fine

AfmanS and others added 2 commits May 23, 2026 16:41
@tillpp

tillpp commented May 23, 2026

Copy link
Copy Markdown

Tested in Linux x86, name rendering looks fine

may I assume you also tested non-latin based names or with diacritics, since harfbuzz is responsible for correctly compositing glyphs ?

@Wunka Wunka moved this to Easy to Review in PRs to review May 31, 2026
@IntegratedQuantum

Copy link
Copy Markdown
Member

Something has changed: Some characters (from trying a few characters on my keyboard I found ∞ ∫ ℝ ℤ ℋ ℜ ℚ) are now oddly blurred. Please look into this and schedule a PR that fixes this behavior in our usage of freetype.
before:
Screenshot at 2026-06-02 19-50-30
after:
Screenshot at 2026-06-02 19-50-10

@IntegratedQuantum IntegratedQuantum moved this from Easy to Review to In review in PRs to review Jun 2, 2026
IntegratedQuantum pushed a commit to PixelGuys/Cubyz that referenced this pull request Jun 22, 2026
Updating freetype to 2.14.3
(PixelGuys/Cubyz-libs#16) causes some glyphs to
be fuzzy. Disabling autohints in glyph loading fixes this. Since the
font is size 16 and textureHeight is 16, it seems to me hints are not
needed.

Disclosure: I had an AI help me with this.

Freetype 2.14.3:
<img width="1410" height="878" alt="Screenshot_20260620_114528"
src="https://github.com/user-attachments/assets/849cb6a4-6302-4bd4-b84e-485d6ab79e75"
/>

Freetype 2.14.3, autohints disabled:
<img width="1410" height="878" alt="Screenshot_20260620_114842"
src="https://github.com/user-attachments/assets/784ef1a3-8741-4770-b2f7-14c3695ea8d9"
/>
@IntegratedQuantum

Copy link
Copy Markdown
Member

Sorry, I totally missed that this can be reviewed again. Could you please rebase the branch so it's up to date with the game?

@AfmanS

AfmanS commented Aug 3, 2026

Copy link
Copy Markdown
Contributor Author

Sorry, I totally missed that this can be reviewed again. Could you please rebase the branch so it's up to date with the game?

Done

@IntegratedQuantum IntegratedQuantum left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work fine now as far as I can tell, thanks

@IntegratedQuantum
IntegratedQuantum merged commit dd62f61 into PixelGuys:master Aug 3, 2026
1 check passed
@AfmanS
AfmanS deleted the harfbuzz branch August 3, 2026 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants