Update harfbuzz and freetype - #16
Merged
Merged
Conversation
Tested in linux x86, name rendering looks fine
may I assume you also tested non-latin based names or with diacritics, since harfbuzz is responsible for correctly compositing glyphs ? |
Member
IntegratedQuantum
pushed a commit
to PixelGuys/Cubyz
that referenced
this pull request
Jun 22, 2026
Updating freetype to 2.14.3 (PixelGuys/Cubyz-libs#16) causes some glyphs to be fuzzy. Disabling autohints in glyph loading fixes this. Since the font is size 16 and textureHeight is 16, it seems to me hints are not needed. Disclosure: I had an AI help me with this. Freetype 2.14.3: <img width="1410" height="878" alt="Screenshot_20260620_114528" src="https://github.com/user-attachments/assets/849cb6a4-6302-4bd4-b84e-485d6ab79e75" /> Freetype 2.14.3, autohints disabled: <img width="1410" height="878" alt="Screenshot_20260620_114842" src="https://github.com/user-attachments/assets/784ef1a3-8741-4770-b2f7-14c3695ea8d9" />
Member
|
Sorry, I totally missed that this can be reviewed again. Could you please rebase the branch so it's up to date with the game? |
Contributor
Author
Done |
IntegratedQuantum
approved these changes
Aug 3, 2026
IntegratedQuantum
left a comment
Member
There was a problem hiding this comment.
Seems to work fine now as far as I can tell, thanks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Tested in Linux x86, name rendering looks fine