Repository navigation
PPPSYS-56851 Fix oauth thundering herd problems - #34
Merged
Merged
Conversation
pmajocha
approved these changes
May 12, 2026
DareYouS
marked this pull request as draft
May 12, 2026 12:16
…621 license metadata
DareYouS
changed the base branch from
master
to
PPPSYS-56851-packaging-ci-refresh
May 13, 2026 11:04
DareYouS
force-pushed
the
PPPSYS-56851-oauth-rate-limit-thundering-herd
branch
from
May 13, 2026 11:12
e0b7967 to
ead5954
Compare
DareYouS
changed the base branch from
PPPSYS-56851-packaging-ci-refresh
to
PPPSYS-56851-ruff-format-import-logs
May 13, 2026 12:11
DareYouS
changed the title
Contributor
|
But that doesn't improve anything beside waiting for the token. I would fix this by storing the token in a file together with the credentials. If subsequent calls to importer are made with the same credentials as in the file, we just use that token. The problem is repeating the import doesn't reuse token in between the calls, not the waiting for the rate limit itself. What is done here is okay, but I'd add some persistance through a file |
mrfijas
removed their request for review
May 18, 2026 10:59
DareYouS
changed the base branch from
PPPSYS-56851-ruff-format-import-logs
to
master
July 16, 2026 09:49
DareYouS
marked this pull request as ready for review
July 16, 2026 13:18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.