-
Notifications
You must be signed in to change notification settings - Fork 5.6k
Zoho Bugtracker - update to API v3 and add new action #19606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
WalkthroughThis PR updates the Zoho BugTracker component with API schema changes, refactored field mappings, and a new dedicated action for file attachments. Key changes include migrating from Changes
Estimated code review effort🎯 4 (Complex) | ⏱️ ~45 minutes Pre-merge checks and finishing touches❌ Failed checks (1 warning, 2 inconclusive)
✅ Passed checks (2 passed)
✨ Finishing touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 7
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
components/zoho_bugtracker/actions/create-bug/create-bug.mjs (1)
95-107: Remove unusedprojectIdfrombugFollowersresolver.The
bugFollowersprop definition in the app file only destructurespageandportalIdfrom the options parameter. PassingprojectIdhere has no effect.🔎 Proposed fix
bugFollowers: { propDefinition: [ zohoBugtracker, "bugFollowers", - ({ - portalId, projectId, - }) => ({ + ({ portalId }) => ({ portalId, - projectId, }), ], optional: true, },
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
📒 Files selected for processing (8)
components/zoho_bugtracker/actions/add-attachment-to-bug/add-attachment-to-bug.mjscomponents/zoho_bugtracker/actions/create-bug/create-bug.mjscomponents/zoho_bugtracker/actions/get-bug-details/get-bug-details.mjscomponents/zoho_bugtracker/actions/update-bug/update-bug.mjscomponents/zoho_bugtracker/common/constants.mjscomponents/zoho_bugtracker/package.jsoncomponents/zoho_bugtracker/sources/new-bug-reported/new-bug-reported.mjscomponents/zoho_bugtracker/zoho_bugtracker.app.mjs
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-10-20T01:01:02.970Z
Learnt from: js07
Repo: PipedreamHQ/pipedream PR: 18744
File: components/slack_v2/actions/send-large-message/send-large-message.mjs:49-64
Timestamp: 2025-10-20T01:01:02.970Z
Learning: In components/slack_v2/actions/send-large-message/send-large-message.mjs, the metadata_event_payload prop is typed as string, so the code only needs to handle string-to-JSON parsing and does not need to handle object inputs.
Applied to files:
components/zoho_bugtracker/actions/update-bug/update-bug.mjs
📚 Learning: 2025-09-15T22:01:11.472Z
Learnt from: GTFalcao
Repo: PipedreamHQ/pipedream PR: 18362
File: components/leonardo_ai/actions/generate-image/generate-image.mjs:103-105
Timestamp: 2025-09-15T22:01:11.472Z
Learning: In Pipedream components, pipedream/platform's axios implementation automatically excludes undefined values from HTTP requests, so there's no need to manually check for truthiness before including properties in request payloads.
Applied to files:
components/zoho_bugtracker/zoho_bugtracker.app.mjs
🧬 Code graph analysis (3)
components/zoho_bugtracker/actions/add-attachment-to-bug/add-attachment-to-bug.mjs (1)
components/zoho_bugtracker/actions/create-bug/create-bug.mjs (1)
response(147-152)
components/zoho_bugtracker/actions/update-bug/update-bug.mjs (1)
components/zoho_bugtracker/actions/create-bug/create-bug.mjs (3)
data(110-120)preData(122-145)response(147-152)
components/zoho_bugtracker/actions/create-bug/create-bug.mjs (1)
components/zoho_bugtracker/actions/update-bug/update-bug.mjs (3)
data(116-126)preData(128-146)response(148-154)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: pnpm publish
- GitHub Check: Verify TypeScript components
- GitHub Check: Publish TypeScript components
- GitHub Check: Lint Code Base
🔇 Additional comments (7)
components/zoho_bugtracker/package.json (1)
3-3: LGTM! Appropriate version bump for API migration and new features.The minor version bump from 0.2.3 to 0.3.0 correctly reflects the addition of the new attachment action and the migration to API v3.
components/zoho_bugtracker/actions/get-bug-details/get-bug-details.mjs (1)
6-6: LGTM! Clean metadata and documentation updates.The version bump, updated documentation URL for API v3, and capitalization fix are all appropriate minor improvements.
Also applies to: 12-12, 59-59
components/zoho_bugtracker/common/constants.mjs (1)
1-1: Constant rename fromrangetolimitis complete. All imports have been updated successfully. The new constant is properly imported in three files (zoho_bugtracker.app.mjs, unbounce.app.mjs, and list-page-leads.mjs), and no remaining references to the old constant name exist.components/zoho_bugtracker/actions/add-attachment-to-bug/add-attachment-to-bug.mjs (1)
73-93: Methods are properly defined and implement the correct two-step attachment process.Both
uploadGlobalAttachment(line 259) andaddAttachmentToIssue(line 268) are defined in zoho_bugtracker.app.mjs using API v3 endpoints. The implementation correctly follows the two-step process: uploading a global attachment first, extracting its ID, then associating it with the issue.components/zoho_bugtracker/actions/update-bug/update-bug.mjs (1)
1-159: LGTM!The update to API v3 is well-implemented. The payload construction with
clearObjcorrectly handles optional fields, and the field mappings (release_milestone,affected_milestone,assigneewithzpuid) align with the Zoho API v3 schema. Thenameprop being optional is appropriate for an update operation.components/zoho_bugtracker/actions/create-bug/create-bug.mjs (1)
109-156: LGTM!The
preDataconstruction is well-structured, correctly mapping fields to the Zoho API v3 schema. The use ofclearObjensures undefined optional fields are excluded from the payload. The pattern is consistent withupdate-bug.mjs.components/zoho_bugtracker/zoho_bugtracker.app.mjs (1)
259-276: The attachment API subdomain is correct. Per Zoho Projects API v3 documentation, attachment endpoints properly use theprojectsapisubdomain with the path/api/v3/portal/{portalId}/attachments. The implementation correctly distinguishes attachment endpoints from other issue management endpoints.
components/zoho_bugtracker/actions/add-attachment-to-bug/add-attachment-to-bug.mjs
Show resolved
Hide resolved
components/zoho_bugtracker/actions/add-attachment-to-bug/add-attachment-to-bug.mjs
Show resolved
Hide resolved
components/zoho_bugtracker/actions/add-attachment-to-bug/add-attachment-to-bug.mjs
Show resolved
Hide resolved
components/zoho_bugtracker/sources/new-bug-reported/new-bug-reported.mjs
Show resolved
Hide resolved
components/zoho_bugtracker/sources/new-bug-reported/new-bug-reported.mjs
Show resolved
Hide resolved
components/zoho_bugtracker/sources/new-bug-reported/new-bug-reported.mjs
Show resolved
Hide resolved
GTFalcao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
For Integration QA: |
|
Hi everyone, all test cases are passed! Ready for release! Test reports
|
Resolves #17251
Summary by CodeRabbit
New Features
Improvements
Updates
✏️ Tip: You can customize this high-level summary in your review settings.