Fix faux « Code invalide » OTP - #8
Merged
Merged
Conversation
Share one SQLite connection for Better Auth and app helpers, keep a singleton OTP verification row, reuse unexpired codes on resend, and normalize pasted OTP input so a valid code is not rejected. Co-authored-by: Pile <pierre@kanta.fr>
PiLep
marked this pull request as ready for review
July 27, 2026 19:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problème
Un code OTP correct pouvait être refusé avec « Code invalide », surtout après un premier essai qui semblait échouer.
Causes principales côté app :
session.createappelaitensurePersonalOrganizationvia une seconde connexion SQLite ; si le provisioning org plantait, la session n’était pas créée alors que le code était déjà brûlé → retry = Invalid OTP.verificationen double — Better Auth email-otp ne déduplique que sur contrainte unique, absente du schéma stock (better-auth#10437) ; mauvais code + renvoi pouvait laisser une ligne périmée gagner.123 456) cassent la comparaison stricte.Correctifs
getDb()→ Better Auth)requireTenantretente ensuite)resendStrategy: "reuse"tant que le code est encore valideTests
npm test(49 tests, dont normalise OTP + index singleton)npx tsc --noEmitOKDéploiement
Redémarrer l’app après déploiement pour appliquer l’index OTP. Si multi-tenant n’a jamais été migré :
npm run auth:migratereste nécessaire.