Skip to content

Stop immediately if the target enters the range during ApproachTarget#2088

Open
TaranDahl wants to merge 1 commit intoPhobos-developers:developfrom
TaranDahl:ApproachTarget_StopMovingWhenInRange
Open

Stop immediately if the target enters the range during ApproachTarget#2088
TaranDahl wants to merge 1 commit intoPhobos-developers:developfrom
TaranDahl:ApproachTarget_StopMovingWhenInRange

Conversation

@TaranDahl
Copy link
Contributor

Stop immediately if the target enters the range during ApproachTarget

  • In vanilla, the ApproachTarget will simply exit and do nothing if the target is in range. This will cause your units to approach the target unnecessarily.
  • Now you can change this behavior by the following flag.

In rulesmd.ini:

[General]
ApproachTarget.StopWhenInRange=false  ; boolean

@TaranDahl TaranDahl added Interaction Something related to interaction with other extension, program etc. Tested ⚙️T1 T1 maintainer review is sufficient ❓Unhardcoding / Customization Make something more tweakable labels Feb 4, 2026
@github-actions
Copy link

github-actions bot commented Feb 4, 2026

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@TaranDahl
Copy link
Contributor Author

The AttackMove.StopWhenTargetAcquired has been deprecated because it was implemented in an incorrect way. It should be ApproachTarget instead of AttackMove that needs to be modified. It has now been replaced by ApproachTarget.StopWhenInRange. The prerequisite for it to take full effect is #2084.

The AttackMove.PursuitTarget has been deprecated because it was implemented in an incorrect way. It should be InAttackMoveKeepRange (implemented by #2081) and ApproachTarget (implemented by #1998) that need to be modified.

@Coronia
Copy link
Contributor

Coronia commented Feb 5, 2026

given there were quite a lot of controversial for our previous tag renaming (such as new Trajectory and the recent major renaming), I think we should still stick to the principal of no tag name change unless necessary. For this PR I think we don't have to depreciate those AttackMove tag, could just redirect their implementaion to the new one.

@TaranDahl
Copy link
Contributor Author

deprecated because it was implemented in an incorrect way

I don't think we should keep something that is incorrect. This is not a simple tag renaming. They are removed because the function itself is incorrect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Interaction Something related to interaction with other extension, program etc. ⚙️T1 T1 maintainer review is sufficient Tested ❓Unhardcoding / Customization Make something more tweakable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants