Skip to content

Conversation

@TaranDahl
Copy link
Contributor

  • Allow techno conversion working on buildings.
  • Fixed the issue that multiple attributes such as cloaking and sensor would not be updated correctly in techno conversion.

@TaranDahl TaranDahl added Interaction Something related to interaction with other extension, program etc. Needs testing ⚙️T1 T1 maintainer review is sufficient ❓Unhardcoding / Customization Make something more tweakable Bugfix This is a bugfix that does not need documentation beyond mention in changelog labels Jan 28, 2026
@github-actions
Copy link

github-actions bot commented Jan 28, 2026

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Coronia
Copy link
Contributor

Coronia commented Jan 29, 2026

perhaps split the fix and building conversion to different PR. Could even commit the previous one to develop directly if you sure it works

@TaranDahl TaranDahl marked this pull request as draft January 29, 2026 07:21
@TaranDahl TaranDahl marked this pull request as ready for review January 29, 2026 12:04
@TaranDahl
Copy link
Contributor Author

Tester confirmed that most of the fixes work.

@Refailure
Copy link

121
1.After the conversion of the building, there are residual issues with the TurretAnim and ActiveAnims, specifically with the Shape turret animation. The Voxel turret does not exhibit any residual effects.
2.Performing a conversion on a building that has an upgrade plugin installed will directly trigger an error.
3.Overlapping issue when surrounding available cells are insufficient.

@Starkku
Copy link
Contributor

Starkku commented Jan 29, 2026

All current building animations should be destroyed and recreated, don't just call GameDelete, there is a function for destroying animation in specific slot.

Upgrades should probably be cleared as well unless they are compatible with the new type.

Allowing changes to Foundation opens a massive can of worms and if it was possible to evaluate at time of parsing should be disallowed entirely but unfortunately it is not. Would discourage against doing such thing and eventual documentation probably at the very least should as well.


@TaranDahl
Copy link
Contributor Author

perhaps split the fix and building conversion to different PR.

Will do after everything is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bugfix This is a bugfix that does not need documentation beyond mention in changelog Interaction Something related to interaction with other extension, program etc. Needs testing ⚙️T1 T1 maintainer review is sufficient ❓Unhardcoding / Customization Make something more tweakable

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants