Skip to content

Inconsistent API between make...With and verify...With + misleading documentation #18

Description

@hce

verifyPasswordWith has an additional parameter of type (Int -> Int) with the description "A function to modify the strength"

makePasswordWith doesn't have this parameter. IMHO it's more consistent to either offer this parameter for both functions or not at all.

Also, the documentation is a bit misleading: "modify the strength" made me assume I just have to use the identity function if I didn't want to modify the strength (and why whould I want to?, I thought) Little did I realize that I needed to supply (2^) if I wanted to be able to successfully verify passwords hashed with makePasswordWith...

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions