Skip to content

Add sound pack for Ferdinand Von Aegir from Fire Emblem Three Houses - #335

Merged
github-actions[bot] merged 3 commits into
PeonPing:mainfrom
JazzFiend:ferdinand-von-aegir
Jul 17, 2026
Merged

Add sound pack for Ferdinand Von Aegir from Fire Emblem Three Houses#335
github-actions[bot] merged 3 commits into
PeonPing:mainfrom
JazzFiend:ferdinand-von-aegir

Conversation

@JazzFiend

Copy link
Copy Markdown
Contributor

No description provided.

@github-actions

Copy link
Copy Markdown
Contributor

❌ Pack Registry Review

Packs

  • Ferdinand von Aegir (FE3H) (ferdinand-von-aegir) — NEW | community | en | 18 sounds

Checks

Check Result
Schema validation FAIL
Trust tier pass
Manifest fetch FAIL
Category coverage FAIL
Audio quality FAIL

Audio Quality

❌ ferdinand-von-aegir: REJECTED

0 audio files analyzed — 0 blocking issues must be fixed

Error: missing source_repo

Category Coverage

❌ ferdinand-von-aegir: FAIL

Error: missing source_repo

Errors

  • packs[102]: missing required field "source_repo"
  • packs[102]: missing required field "source_ref"
  • packs[102]: missing required field "source_path"
  • ferdinand-von-aegir: missing source_repo
  • ferdinand-von-aegir: missing source_repo

Some checks failed. Please fix the issues above and push again.

@github-actions

Copy link
Copy Markdown
Contributor

❌ Pack Registry Review

Packs

  • Ferdinand von Aegir (FE3H) (ferdinand-von-aegir) — NEW | community | en | 18 sounds

Checks

Check Result
Schema validation pass
Trust tier pass
Manifest fetch FAIL
Category coverage FAIL
Audio quality FAIL

Audio Quality

❌ ferdinand-von-aegir: REJECTED

0 audio files analyzed — 0 blocking issues must be fixed

Error: download failed: HTTP Error 404: Not Found

Category Coverage

❌ ferdinand-von-aegir: FAIL

Error: HTTP Error 404: Not Found

Errors

Some checks failed. Please fix the issues above and push again.

@github-actions

Copy link
Copy Markdown
Contributor

✅ Pack Registry Review

Packs

  • Ferdinand von Aegir (FE3H) (ferdinand-von-aegir) — NEW | community | en | 18 sounds

Checks

Check Result
Schema validation pass
Trust tier pass
Manifest fetch pass
Category coverage pass
SHA256 (ferdinand-von-aegir) pass
Audio spot-check (ferdinand-von-aegir) pass (3/3)
• sounds/22.wav
• sounds/24.wav
• sounds/A_true_noble_never_fails.wav
Audio quality pass

Audio Quality

✅ Ferdinand von Aegir (FE3H): SILVER

19 audio files analyzed — Accepted with 2 warnings

Warnings — pack is accepted, but please consider addressing these in a future release:

File Issue
It_begins.wav volume is very high, may sound distorted on some devices
What_now.wav volume is very high, may sound distorted on some devices
Threshold reference
Check Block Warn
Volume (true peak) >= -0.5 dBTP
Dead air at start > 2000 ms > 500 ms
Dead air at end > 2000 ms > 500 ms
Loudness (LUFS) < -70.0 < -35.0 or > -8.0
Bitrate < 64 kbps
Sample rate < 8000 Hz < 16000 Hz
Duration > 20.0s or < 0.1s > 5.0s
Pack loudness spread > 15 LU
Pack median loudness <= -26 LUFS

Category Coverage

⚠️ ferdinand-von-aegir: PASS (with warnings)

19 sounds across 6/6 core categories

Category Sounds Status
session.start 1 ⚠️ thin
task.acknowledge 4
task.complete 4
task.error 4
input.required 2
resource.limit 3

Pack is accepted, but please consider addressing thin categories in a future release.

Warnings

  • ferdinand-von-aegir: sound_count=18 but manifest references 19 unique files
  • ferdinand-von-aegir: core categories with only 1 sound: session.start

All checks passed. Auto-approving and enabling auto-merge.

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All automated checks passed.

@github-actions
github-actions Bot enabled auto-merge (squash) July 17, 2026 22:44
@github-actions
github-actions Bot merged commit b722b9f into PeonPing:main Jul 17, 2026
1 check passed
@JazzFiend
JazzFiend deleted the ferdinand-von-aegir branch July 17, 2026 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants