Fix bug in PCPhase bind #2467
Open
Fix bug in PCPhase bind #2467
+7
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- temporary workaround was causing errors in benchmarks
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2467 +/- ##
==========================================
+ Coverage 96.74% 96.75% +0.01%
==========================================
Files 156 156
Lines 16937 16990 +53
Branches 1648 1653 +5
==========================================
+ Hits 16385 16438 +53
- Misses 402 403 +1
+ Partials 150 149 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JerryChen97
requested changes
Feb 6, 2026
Contributor
JerryChen97
left a comment
JerryChen97
left a comment
There was a problem hiding this comment.
Might need sync the submodule so that we dont touch enzyme etc via this pr🤔
JerryChen97
reviewed
Feb 9, 2026
Contributor
JerryChen97
left a comment
JerryChen97
left a comment
There was a problem hiding this comment.
Also mind add a minimal test somewhere? Not sure if this is easy to do; curious why Catalyst's tests never caught this obvious bug...
maliasadi
reviewed
Feb 10, 2026
| *wires, | ||
| angle, | ||
| dim, | ||
| *ctrl_wires, |
Member
There was a problem hiding this comment.
Could you add tests in frontend/tests/pytest/from_plxpr?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context: We are trying to see if we can run certain circuits with capture, qjit and decomposition. At the moment, this is limited by an error arising from
jax_primitivesdue to a workaround which has thus far been left in place in the bind function ofPCPhase.Description of the Change: We remove the workaround and match the signature of the
PCPhaseto what is expected injax_primitives.Benefits: We are closer to using
PCPhasein circuits with capture, qjit and decomps.Possible Drawbacks: Not sure yet how this change will propagate.
Related ShortCut Stories: [sc-101673] [sc-101776]