Skip to content

fix(search): use lucide-react icons in SearchBar instead of unicode glyphs #656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nonsobethel0-dev merged 2 commits into from
Sep 24, 2026
Merged

fix(search): use lucide-react icons in SearchBar instead of unicode glyphs #656

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6594bb1
fix(search): use lucide Search icon instead of emoji in SearchBar
laurastephaniee Sep 24, 2026
90cc507
fix(search): use lucide X icon for SearchBar clear button, add tests
laurastephaniee Sep 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/__tests__/SearchBar.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,13 @@ describe('SearchBar', () => {
expect(html).toContain('type="text"');
});

it('renders the lucide Search icon instead of an emoji (#651)', () => {
const html = renderToStaticMarkup(<SearchBar onSearch={vi.fn()} />);
expect(html).toContain('lucide-search');
expect(html).toContain('aria-hidden="true"');
expect(html).not.toContain('🔍');
});

it('does not render clear button when query is empty', () => {
const onSearch = vi.fn();
const html = renderToStaticMarkup(<SearchBar onSearch={onSearch} />);
Expand Down Expand Up @@ -91,7 +98,11 @@ describe('SearchBar debouncing', () => {
});
onSearch.mockClear();

fireEvent.click(screen.getByLabelText('Clear search'));
const clear = screen.getByLabelText('Clear search');
expect(clear.querySelector('svg.lucide-x')).not.toBeNull();
expect(clear.textContent).not.toContain('✕');

fireEvent.click(clear);
expect(onSearch).toHaveBeenCalledWith('');
expect((screen.getByRole('textbox') as HTMLInputElement).value).toBe('');
});
Expand Down
13 changes: 8 additions & 5 deletions src/components/SearchBar.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

import { useState, useEffect } from 'react';
import { usePathname } from 'next/navigation';
import { Search, X } from 'lucide-react';
import { useDebounce } from '@/hooks/useDebounce';

interface SearchBarProps {
Expand Down Expand Up @@ -35,9 +36,11 @@ export function SearchBar({

return (
<div className={`relative ${className ?? ''}`}>
<span className="pointer-events-none absolute left-3 top-1/2 -translate-y-1/2 text-gray-400">
🔍
</span>
<Search
size={16}
aria-hidden="true"
className="pointer-events-none absolute left-3 top-1/2 -translate-y-1/2 text-gray-400"
/>
<input
type="text"
value={query}
Expand All @@ -52,10 +55,10 @@ export function SearchBar({
setQuery('');
onSearch('');
}}
className="absolute right-3 top-1/2 -translate-y-1/2 text-xs text-gray-400 hover:text-white transition-colors"
className="absolute right-3 top-1/2 -translate-y-1/2 text-gray-400 hover:text-white transition-colors"
aria-label="Clear search"
>
✕
<X size={14} aria-hidden="true" />
</button>
)}
</div>
Expand Down