fix: add Badge icon prop, Storage security error handling, Logo text, Toast memo - #644
Merged
nonsobethel0-dev merged 1 commit intoSep 24, 2026
Conversation
… text, ToastItem memo Closes Parashield-Protocol#600 Closes Parashield-Protocol#601 Closes Parashield-Protocol#602 Closes Parashield-Protocol#603 - Add optional icon prop to Badge component for custom icons (Parashield-Protocol#600) - Detect SecurityError in storage module and warn once (Parashield-Protocol#601) - Fix LogoWordmark variant for shield text color visibility (Parashield-Protocol#602) - Memoize ToastItem to prevent unnecessary re-renders (Parashield-Protocol#603)
|
@benfoster-dev Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
❌ Deploy Preview for boisterous-sunshine-dd4c4c failed.
|
nonsobethel0-dev
merged commit Sep 24, 2026
2a00e12
into
Parashield-Protocol:main
0 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #600
Closes #601
Closes #602
Closes #603
What changed
iconprop to Badge component for custom icons ([ux] Badge component does not support custom icons #600)SecurityErrorin storage module and warn once ([security] storage module silently ignores all errors including security exceptions #601)Details
#600 - Badge Custom Icons
iconprop toBadgePropsinterface#601 - Storage SecurityError Handling
warnSecurityErrorhelper that logs warning once per sessionSecurityErrorDOMException and warns about disabled storageget,set,remove,getSession,setSession,removeSession#602 - LogoWordmark Text Color
text-gray-900for light mode,text-whitefor dark mode#603 - ToastItem Memo
ToastItemcomponent withReact.memo