Repository navigation
Fix Parashield Frontend Issues (#580, #581, #582, #583) - #639
Merged
Merged
Conversation
|
@Ultra-Tech-code Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
❌ Deploy Preview for boisterous-sunshine-dd4c4c failed.
|
nonsobethel0-dev
merged commit Sep 24, 2026
72918bc
into
Parashield-Protocol:main
0 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses four assigned issues related to UI/UX, accessibility, and performance improvements across the Parashield frontend.
Changes Made
The following atomic commits have been implemented:
ProductCard(closes [ux] ProductCard does not show min coverage amount #580)Min Coveragefield to the statistics grid insideProductCardfor clearer policy details.SearchBaron navigation to homepage (closes [bug] SearchBar does not clear when navigating back to homepage #581)usePathnamefromnext/navigationto detect route changes and properly reset the search query state when returning to the homepage.aria-pressedtoCategoryFilterbuttons (closes [a11y] CategoryFilter buttons missing aria-pressed attribute #582)aria-pressedattribute to the category buttons to properly indicate their active/inactive state to screen readers.CompareModalre-renders via memoization (closes [perf] CompareModal renders all product details even when only 2 products selected #583)CompareModalinReact.memoand passed a memoizedonClosehandler to prevent unnecessary re-renders of the modal.Testing
ProductCardvisually includes both Min Coverage and Max Coverage./properly clears theSearchBarinput.CategoryFiltertoggle buttons.CompareModalhandles toggling and comparisons performantly without excess component updates.Closes #580
Closes #581
Closes #582
Closes #583