Repository navigation
fix: resolve 4 Stellar Wave issues (#564-567) - #634
Merged
nonsobethel0-dev merged 4 commits intoSep 23, 2026
Merged
nonsobethel0-dev merged 4 commits into
nonsobethel0-dev merged 4 commits into
Conversation
Define a SignMessageCapable interface instead of using 'as unknown as' to access kit.signMessage. This preserves TypeScript type safety while still supporting the runtime method that may not be declared in all package versions.
The policy detail breadcrumb only included the category icon when the product had a category. Now it uses a fallback shield icon for visual consistency when category data is missing.
… devices Add onPointerDown stopPropagation handler to the compare checkbox label to ensure touch events don't bubble up and open the buy modal.
Separate initial load errors from background poll failures in usePolicies. Background poll errors now set pollingError instead of error, preventing the policies list from being replaced with a blocking error state when only a background refresh fails.
|
@oomokaro1 Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
❌ Deploy Preview for boisterous-sunshine-dd4c4c failed.
|
nonsobethel0-dev
merged commit Sep 23, 2026
7bb0f41
into
Parashield-Protocol:main
0 of 5 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #564, Closes #565, Closes #566, Closes #567
Type of Change
Summary
This PR addresses 4 issues from the Stellar Wave program:
[security] signAuthMessage casts kit to untyped object to access signMessage #567: Replaced unsafe
as unknown astype cast with a namedSignMessageCapableinterface insignAuthMessage, preserving TypeScript type safety while maintaining runtime compatibility.[ux] Policy detail page does not show product category icon in breadcrumb #566: Fixed policy detail breadcrumb to always show the category icon with a fallback shield icon when product category data is missing, ensuring visual consistency.
[bug] ProductCard compare checkbox does not prevent card click propagation #565: Added
onPointerDownstopPropagation handler to the ProductCard compare checkbox to prevent touch events from bubbling up and triggering the buy modal.[bug] usePolicies does not expose pollingError like useClaims does #564: Added
pollingErrorstate tousePolicieshook (matching the pattern inuseClaims) so background poll failures don't overwrite the policies list with a blocking error.Motivation / Context
These issues improve type safety, UI consistency, touch device usability, and error handling resilience across the Parashield frontend.
Closes #564, Closes #565, Closes #566, Closes #567