fix(api): stop leaking wallet address in /policies query string (#525)

[springswell]

Summary

fetchUserPolicies in src/lib/api.ts sent the connected wallet as a query parameter: GET /policies?wallet=G.... Query strings get written to server and proxy access logs and to browser history, so the user's Stellar address leaked in plaintext.

Why the param can simply be removed

The backend already ignores it. In parashield-backend/src/policy/policy.controller.ts, getMyPolicies only reads page and limit from the query string and resolves the wallet from the authenticated request (req.user?.walletAddress || req.wallet):

#345 — wallet used to come from a client-supplied query param … the JWT wallet was always the one actually used, making the param redundant

The axios client already attaches Authorization: Bearer <token> to every request, so removing the param changes nothing on the backend. It also doesn't need moving to a body or a header.

Changes

Commit 1: fix

• src/lib/api.ts: fetchUserPolicies() takes no argument and calls GET /policies with no query string. Added a doc comment explaining why.
• src/hooks/usePolicies.ts: calls fetchUserPolicies(). It still skips fetching while no wallet is connected, and still refetches or aborts when the wallet changes.

Commit 2: tests (src/__tests__/usePolicies.test.tsx)

• New regression test: fetchUserPolicies is called with no arguments.
• The existing stale-response test used the wallet argument to track in-flight requests. It now uses the wallet that was active when each call was made. What it checks is unchanged.

Testing

npx vitest run src/__tests__/usePolicies.test.tsx src/hooks/__tests__/usePolicies.test.ts
 Tests  1 failed | 13 passed (14)

• The one failure is usePolicy > refetch allows manual refresh independent of id changes. It also fails on main without this change, and it tests usePolicy, not the code changed here.
• src/lib/__tests__/api.test.ts also fails on main before any of these changes (Cannot read properties of undefined (reading 'interceptors')). That is unrelated.
• tsc --noEmit reports no errors in the changed files.

Out of scope / follow-up

• fetchUserClaims also sends ?wallet=. The backend's GET /claims still requires that param (@Query('wallet'), with a 403 if it doesn't match the JWT), so removing it on the frontend alone would break claims. That needs a coordinated backend change first, like [Perf] Home page re-renders all product cards on every search keystroke despite debounce #345 for policies.
• fetchChallenge (/auth/challenge?wallet=) runs before authentication, so there is no JWT to take the wallet from.
  Closes [security] Wallet address passed as query parameter in fetchUserPolicies #525
  Closes [ux] Export dropdown doesn't close on outside click when button is inside a scrollable container #524
  Closes [perf] useClaims hook creates new AbortController on every refetch call #527
  Closes [bug] ErrorBoundary fallback doesn't receive error details #526

[drips-wave]

@springswell Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

[netlify]

❌ Deploy Preview for boisterous-sunshine-dd4c4c failed.

Name	Link
🔨 Latest commit	bb9ad91
🔍 Latest deploy log	https://app.netlify.com/projects/boisterous-sunshine-dd4c4c/deploys/6ab4213d73334b0008a5e5d6