Convert PlayerChooseInitialServerEvent into a resulted event#1787
Convert PlayerChooseInitialServerEvent into a resulted event#1787electronicboy wants to merge 2 commits intodev/3.0.0from
Conversation
| Component.translatable("velocity.error.no-available-servers", NamedTextColor.RED)), | ||
| true); | ||
| //noinspection UnnecessaryReturnStatement | ||
| return; |
There was a problem hiding this comment.
//noinspection UnnecessaryReturnStatement
return;Seems unnecessary? I don't see why you would want a return here?
Maybe one of those fancy new switch "instanceof" statements would be better here anyway (JEP 441), throwing on default (unknown/unexpected result type)
There was a problem hiding this comment.
I'd originally wrote this without the else statement and then remembered I needed it so I could for the if anyways. I do know that IJ itself tended to get upset with shorter case switches and so I did tend to avoid them for stuff like this
There was a problem hiding this comment.
Fair enough, still I think line 270 and 271 can be deleted
| } | ||
|
|
||
| public record Denied(@Nullable Component reason) implements Result { | ||
| public static @NotNull Result of(@Nullable Component reason) { |
There was a problem hiding this comment.
Inconsistent formatting (no whitespace after class declaration, Allowed does have this)
Is it an idea to force this with checkstyle? Whitespace after class declaration, or newline checking in general, idk if we currently have this. Iirc this is quite inconsistent in the codebase
There was a problem hiding this comment.
Yea, we don't really have a hard rule on this and it's pretty easy to miss when refactoring during working on something, need to update checkstyle and formalise rules for this stuff
2 participants
No description provided.