Add save cosplay saber force uses - #77
Merged
Merged
Conversation
Owner
|
The use case described here is pretty niche, but I can also imagine the possibility of some hypothetical world event utilizing some of the saber skills, so I'm not against it. The implementation is fine too - we make the same greedy assumption in many other places in the script. I think having a knapsack is out of scope for now - users who need that level of optimization should probably create and maintain their own personal fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds ability to save uses of cosplay saber.
In my usecase, I mostly just need to disable the cosplay saber when using familiars that deal damage.
This is sub-optimal, in that if you're just limiting it to a value between 0 and 5, it may burn the uses on the tasks that don't need it. Fixing that however, would be a proposal of a knapsack script.