Skeletons v2 - Allow tasks to say they were not attempted - #74
Conversation
… NC or time cop, it wasn't a real attempt
|
I like this approach! And yes I do think that there might be value in getting the engine to run a default My sole concern is with the messing around with |
|
Seems to work fine for me, lastEncounter was cleared as expected. Though oddly, it went back in because of |
|
No typo there. The original low shiny path really needed some of these turn-burning actions at the right place and time to set up the trainset + bowling ball, and these artifacts remain since we remain committed to supporting the original low shiny run plan. |
So this PR is a different approach as the base issue as I see it, is really that the engine logs it as an attempt, when it wasn't a proper attempt.
The first commit introduces a new parameter that tasks can implement, a function that lets them declare if the task was indeed attempted or not.
This could potentially be expanded for other tasks, that have encounters that were distractions and didn't actually attempt the real task.
Skeletons now have a choice set to skip the scheduled NC, and will not mark the task as attempted if it hit either NC, or a time cop.
Haven't tested it, will do tomorrow though don't expect any issues.
If this approach doesn't seem good, lmk and I'll do a third PR where it simply adds the choices without looking at the initial NC 👍