chore: bump Node to 22 across CI and add engines pin#1351
Closed
sserrata wants to merge 1 commit into
Closed
Conversation
Node 20 goes EOL 2026-04. Bumping the CI workflows and adding an `.nvmrc` + `engines` floor unblocks dev dependencies (e.g. lint-staged v17) that already require Node >=22, and gives contributors a clear install-time signal when their local Node is out of date. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Member
Author
|
Parking this until closer to Node 20 EOL (2026-04). The workflow bump is provably correct but can't self-validate due to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
actions/setup-nodeversion from'20'→'22'in bothdeploy-preview.yml(2 refs) anddeploy-live.yml(2 refs).nvmrcpinning Node22for local dev / IDE tooling"engines": { "node": ">=22.0.0" }topackage.jsonsoyarn installgives contributors a clear signal if they're on an older NodeWhy
lint-staged16 → 17, which needs>=22.22.1)Impact
yarn install; they'll need to bump (nvm usewill pick up the new.nvmrc)Test plan
@dependabot rebaseon Bump lint-staged from 16.4.0 to 17.0.8 #1330 solint-stagedv17 installs cleanly🤖 Generated with Claude Code