Skip to content

Make soft delay optional - #106

Merged
ckolbPTB merged 2 commits into
PTB-MR:mainfrom
ckolbPTB:soft_delay
Sep 3, 2026
Merged

ckolbPTB merged 2 commits into
PTB-MR:mainfrom
ckolbPTB:soft_delay

Conversation

@ckolbPTB

@ckolbPTB ckolbPTB commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

The soft delay option is not yet widely supported by different pulseq interpreters. Here we make it optional.

@ckolbPTB
ckolbPTB requested a review from schuenke September 2, 2026 14:48
@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Coverage

Coverage Report
FileStmtsMissCoverMissing
/home/runner/.local/lib/python3.12/site-packages/mrseq
   _version.py770%2–9
/home/runner/.local/lib/python3.12/site-packages/mrseq/preparations
   t2_prep.py51198%195
/home/runner/.local/lib/python3.12/site-packages/mrseq/sequences
   epi2d_fid.py128993%256, 359, 416–421, 433, 439
   epi2d_se.py1481292%204–206, 317, 420, 477–482, 494, 500
   grpe_flash_dixon.py2051891%121, 124, 189, 206–208, 330, 349, 400, 410, 512, 580–585, 597, 603
   radial_flash.py1401192%101, 104, 259, 353, 411–416, 428, 434
   spiral_flash.py1201092%95, 231, 320, 370–375, 387, 393
   t1_inv_rec_gre_single_line.py93990%162, 263, 306–311, 330, 336
   t1_inv_rec_se_single_line.py106992%219, 324, 383–388, 407, 413
   t1_molli_bssfp.py1451391%221, 289–291, 306, 391, 446–451, 463, 469
   t1_t2_spiral_cmrf.py1531292%93, 99, 118, 172, 405, 453–458, 472, 478
   t1rho_se_single_line.py102892%318, 375–380, 399, 405
   t2_multi_echo_se_single_line.py96991%162, 268, 321–326, 344, 350
   t2_t2prep_flash.py1471590%107, 231, 249, 284–286, 298, 383, 446–451, 463, 469
   t2star_multi_echo_flash.py1471490%118, 238, 286–288, 300, 405, 468–473, 485, 491
/home/runner/.local/lib/python3.12/site-packages/mrseq/utils
   EpiReadout.py3319073%52, 61, 193, 197, 244, 318, 321–332, 454, 507–591, 737–743, 763–808
   cartesian_sampling.py37295%38, 80
   sequence_helper.py59493%105, 133–134, 162
   spiral_sampling.py67199%79
TOTAL246325490% 

Tests Skipped Failures Errors Time
1491 0 💤 0 ❌ 0 🔥 2m 12s ⏱️

@ckolbPTB
ckolbPTB merged commit df03749 into PTB-MR:main Sep 3, 2026
9 checks passed
@ckolbPTB
ckolbPTB deleted the soft_delay branch September 3, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants