Skip to content

UHM-7260: Add Patient Flags module to the PIH EMR distro#440

Open
mogoodrich wants to merge 1 commit into
masterfrom
UHM-7260
Open

UHM-7260: Add Patient Flags module to the PIH EMR distro#440
mogoodrich wants to merge 1 commit into
masterfrom
UHM-7260

Conversation

@mogoodrich

Copy link
Copy Markdown
Member

No description provided.

@mogoodrich
mogoodrich requested a review from mseaton July 12, 2023 19:22

@mseaton mseaton left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks fine, if you think the module is in good enough shape to add in, in it's current form.

@mogoodrich

Copy link
Copy Markdown
Member Author

Maybe this is famous last words, but I don't think it can hurt anything in it's current shape, especially if we don't have any flags set up. That being said, I think it may introduce some AOP, so maybe better to hold on this until after the LIberia release.

@mseaton

mseaton commented Jul 13, 2023

Copy link
Copy Markdown
Member

I don't think it can hurt anything in it's current shape

Just add 5 new tables to the data model, add AOP around every EncounterService save, add additional spring context stuff that needs to startup, and add more modules to maintain, but yeah. On a more meta level, it's more subtly communicating that this is not something we are comfortable with in it's current form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants