Conversation
… promote caching)
There was a problem hiding this comment.
perhaps the control flow could be simplified, line 16 and line 102 are very similar
There was a problem hiding this comment.
This is fine for now, I'd rather get this merged and then clean this part up later.
There was a problem hiding this comment.
changed from pass to skip for unsupported combinations
vbharadwaj-bk
left a comment
vbharadwaj-bk
left a comment
There was a problem hiding this comment.
Looks good, and some of these smaller things can be cleaned up later; can you add a workflow file under .github/workflows, like so?
https://github.com/ACEsuit/mace/blob/main/.github/workflows/pre-commit.yaml
You don't need to select any version of pip or install flake8, black, etc., only pip install ruff is necessary. The last line of the file above runs the pre-commit check.
There was a problem hiding this comment.
This is fine for now, I'd rather get this merged and then clean this part up later.
|
Also, you seem to have a conflict with main, so make sure to pull and merge. |
2 participants
Added Ruff and pre-commit for python formatting and linting