Repository navigation
fix(metrics): roll response times that round to 60s over to minutes - #136
Merged
FallDownTheSystem merged 2 commits intoOct 17, 2026
Merged
FallDownTheSystem merged 2 commits into
FallDownTheSystem merged 2 commits into
Conversation
Applies the same rounding at the minutes-to-hours boundary, since total API time can pass an hour in long sessions.
Collaborator
|
Small addition from my side: total API time can go past an hour in a long session, so it rolls over to hours now too. Merging this one, you'll be listed as the author. |
FallDownTheSystem
approved these changes
Oct 17, 2026
Member
|
🎉 This PR is included in version 1.32.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Response times between 59.95s and 60s were shown as "60.0s" instead of rolling over to minutes. The seconds/minutes switch checked
seconds < 60, but the value is then rounded to one decimal, so anything from 59.95 up rounded to "60.0s". The same check was copied into the status line metrics segment for both response time and last response time, as well asformatResponseTimeused by the TUI.formatResponseTimenow switches to minutes at 59.95s, so 59.97s shows as "1.0m". The metrics segment callsformatResponseTimeinstead of repeating the logic. Tests cover the formatter boundary and the rendered metrics segment.