fix(upgrade): use sha256 lock key hash in acquire_upgrade_lock in bootstrap-upgrade.sh - #2828
Open
vaibhavsrv wants to merge 2 commits into
Open
fix(upgrade): use sha256 lock key hash in acquire_upgrade_lock in bootstrap-upgrade.sh#2828vaibhavsrv wants to merge 2 commits into
vaibhavsrv wants to merge 2 commits into
Conversation
…tstrap-upgrade.sh
…ootstrap-upgrade.sh
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
ods/scripts/bootstrap-upgrade.sh,acquire_upgrade_lock()computes the lock directory name using rawcksum. Output formatting and checksum algorithms forcksumdiffer between GNU coreutils on Linux and BSDcksumon macOS. If upgrade processes run across mixed host environments, inconsistent lock directory names allowed multiple model upgrade routines to run concurrently, risking corrupted GGUF downloads.Fix
Update
acquire_upgrade_lock()to use standard SHA-256 hashing (sha256sum 2>/dev/null || shasum -a 256 2>/dev/null || cksum) for cross-platform lock key generation inbootstrap-upgrade.sh.Verification
Ran
bash -n ods/scripts/bootstrap-upgrade.sh(passed cleanly). Verified lock key hashing on Linux and macOS.git diff --checkpassed cleanly.