fix(detection): add sysctl hw.ncpu lookup on macOS in detection.sh - #2827
Open
vaibhavsrv wants to merge 1 commit into
Open
fix(detection): add sysctl hw.ncpu lookup on macOS in detection.sh#2827vaibhavsrv wants to merge 1 commit into
vaibhavsrv wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
ods/installers/lib/detection.sh,get_host_logical_cpus()resolves system CPU core count usingnproc 2>/dev/null || grep -c ^processor /proc/cpuinfo. On macOS (Darwin), neithernprocnor/proc/cpuinfoexist by default, causingget_host_logical_cpus()to fall back to1core. This led to under-allocated thread counts (--threads 1) duringllama-serverCPU thread budget calculation on Apple Silicon Macs.Fix
Add
sysctl -n hw.ncpu 2>/dev/nullas the primary hardware query inget_host_logical_cpus()indetection.sh.Verification
Ran
bash -n ods/installers/lib/detection.sh(passed cleanly). Verified CPU core count resolution on macOS.git diff --checkpassed cleanly.