fix(doctor): use context manager and errors=replace in inline python in ods-doctor.sh - #2820
Open
vaibhavsrv wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
ods/scripts/ods-doctor.sh, inline Python helper reads capability profiles using barejson.load(open(path, "r", encoding="utf-8")). Leaving the file handle open without a context manager risks resource leaks on long-running diagnostic checks. Furthermore, if non-UTF-8 characters exist in custom capability profile files,open(..., encoding="utf-8")raised an uncaughtUnicodeDecodeError.Fix
Update inline Python in
ods-doctor.shto use awith open(path, "r", encoding="utf-8", errors="replace") as f:context manager.Verification
Ran
bash -n ods/scripts/ods-doctor.sh(passed cleanly).git diff --checkpassed cleanly.