fix(preflight): reap timed-out Docker probes - #2819
Open
tang-vu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
docker --versionprocess when the preflight probe times outWhy this matters
GET /api/preflight/dockerruns during setup and diagnostics. If the Docker CLI hangs,asyncio.wait_forcancelscommunicate()but does not terminate the operating-system process. Repeated preflight requests can therefore leave blocked Docker clients and unreaped children behind in dashboard-api. The endpoint now owns the complete lifecycle of the subprocess it starts.Overlap check
Searched open and closed upstream PRs for
preflight docker timeout subprocess kill,preflight_docker create_subprocess_exec, and the changed production path inextensions/services/dashboard-api/main.py. No PR covers cleanup of the Docker preflight child. Existing subprocess cleanup changes target different endpoints and services.Test plan
python -m pytest -q ods/extensions/services/dashboard-api/tests/test_routers.py(55 passed)python -m py_compile ods/extensions/services/dashboard-api/main.py ods/extensions/services/dashboard-api/tests/test_routers.pygit diff --checkThe regression test calls the authenticated
/api/preflight/dockerboundary, forces the child communication to time out, and verifies bothkill()andwait()occur before the timeout response is returned.Generated with Codex.