fix(uninstall): keep sudo password prompts terminal-safe - #2810
Open
tang-vu wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sudo -vsteptimeoutand stderr-redirection wrappersods-uninstall.sh --forceflow with a sudo-call-order regression testWhy this matters
Closes #2623.
ods-uninstall.sh --forcereaches privileged systemd, symlink, and ownership cleanup on normal Linux installs. The systemd path wrapped an interactivesudoprocess intimeoutwhile redirecting its prompt, which can break terminal echo handling and was reported to print the operator's password on Debian 13. The new boundary performs credential acquisition directly on the terminal, then makes every wrapped command non-interactive.Overlap check
Searched open and closed PRs for
uninstall sudo password prompt,ods-uninstall sudo -v, issue#2623, and changes toods/ods-uninstall.sh. No PR addresses the reported terminal-echo failure. Existing uninstall PRs cover checkout deletion, Compose cleanup, and path guards; none separates interactive authentication from timed privileged commands.Test plan
bash -n ods/ods-uninstall.sh ods/tests/test-uninstall-compose-flags.shbash ods/tests/test-uninstall-compose-flags.shgit diff --checkGenerated with Codex