fix(demo): guard read in pause for non-interactive execution in demo-offline.sh - #2809
Open
vaibhavsrv wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In
ods/scripts/demo-offline.sh, helper functionpause()pauses execution between interactive demo steps by callingread -r. Whendemo-offline.shis executed non-interactively or in automated CI/documentation screenshot pipelines without an interactive TTY,read -rencounters an Immediate EOF or non-zero exit code underset -e, causing script failure.Fix
Add
[[ -t 0 ]] || return 0TTY check inpause()to bypass interactive pauses in headless environments, and append|| truetoread -rindemo-offline.sh.Verification
Ran
bash -n ods/scripts/demo-offline.sh(passed cleanly). Verified headless pipe execution via./scripts/demo-offline.sh < /dev/null.git diff --checkpassed cleanly.