build: migrate JS tooling from yarn to pnpm#204
Merged
naddison36 merged 5 commits intomainfrom Apr 7, 2026
Merged
Conversation
- Replace yarn with pnpm in Makefile install/clean targets - Pin pnpm via packageManager field in package.json - Update CI setup action to use pnpm/action-setup + setup-node cache - Rename install-yarn input to install-pnpm in workflows - Regenerate lockfile (yarn.lock -> pnpm-lock.yaml) - Update doc references in CLAUDE.md files
Specifying both `version: 9` in the action and `packageManager: pnpm@9.15.0` in package.json triggers ERR_PNPM_BAD_PM_VERSION. Drop the explicit input so the action picks up the pinned version from package.json.
The flyTradeQuote hardhat task now catches axios errors with status 525 (Cloudflare SSL handshake failure with origin) and emits a sentinel hex to stdout instead of throwing. Helpers.sol detects that sentinel from vm.ffi output and calls vm.skip(true), so transient upstream outages mark the test as skipped instead of failing CI.
clement-ux
changed the title
naddison36
previously approved these changes
Apr 7, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
naddison36
approved these changes
Apr 7, 2026
Collaborator
naddison36
left a comment
naddison36
left a comment
There was a problem hiding this comment.
I've tested my common Hardhat tasks and they are working.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrates the JavaScript dependency manager from yarn (classic v1) to pnpm for faster installs, smaller
node_modulesvia the content-addressable store, and stricter dependency hoisting.Changes
pnpm migration
Makefile—yarn install→pnpm install;clean-allnow removespnpm-lock.yamlpackage.json— added"packageManager": "pnpm@9.15.0"so Corepack picks the right version automatically.github/actions/setup/action.yml— replaced manual yarn cache step with the standard pnpm CI pattern:pnpm/action-setup@v4+actions/setup-node@v4(Node 20,cache: 'pnpm'); renamed inputinstall-yarn→install-pnpm. The action reads the pnpm version directly frompackage.json#packageManager.github/workflows/main.yml— 4 jobs updated toinstall-pnpm: 'true'CLAUDE.md/.claude/CLAUDE.md— doc references updatedyarn.lockdeleted,pnpm-lock.yamlcommittedTest fixes (unrelated pre-existing CI failures, fixed here to get the PR green)
13fb74dfrom Reduced the Ethena ARM DELAY_REQUEST from 3 hours to 30 minutes #203: updatesmorphoMarketreference and adjusts the WETH allocation intest_allocate_to_lending_marketto account for outstanding withdrawals, so the assertion holds against current mainnet state.flyTradeQuotehardhat task now emits a sentinel hex (0xc10ad11ae525) and exits 0 instead of crashing.Helpers.getFlyTradeQuotedetects that sentinel fromvm.ffioutput and callsvm.skip(true), so transient upstream outages mark the test as skipped rather than failing CI. Only 525 triggers the skip — every other failure mode still surfaces as a real test failure.Notes
dependencies/@pendle-sy-1.0.0-1.0.0/yarn.lockis left untouched (it belongs to a vendored Soldeer dep).Test plan
pnpm installsucceeds and producespnpm-lock.yamlpnpm lintpassespnpm prettier:checkpassespnpm rollup -c src/js/actions/rollup.config.cjsbundles all Defender Actionsbuild,unit-tests,fork-tests,smoke-testsjobs install pnpm and pass