Skip to content

Updated opsorch-core to 0.0.4 - #1

Merged
yusufaytas merged 1 commit into
mainfrom
core-v0.4-upgrage
Jan 5, 2026
Merged

yusufaytas merged 1 commit into
mainfrom
core-v0.4-upgrage

Conversation

@yusufaytas

Copy link
Copy Markdown
Contributor

No description provided.

@greptile-apps

greptile-apps Bot commented Jan 4, 2026

Copy link
Copy Markdown

Greptile Summary

Updated opsorch-core dependency from v0.0.4 to v0.4.0 and added permalink URL support to Slack message results.

Key Changes:

  • Bumped opsorch-core to v0.4.0 to support URL field in MessageResult
  • Added Slack permalink retrieval via GetPermalinkContext in Send() method
  • Updated integration tests to display message URLs when available
  • Added .env.local to gitignore for local environment configuration

Notes:

  • The commit message says "Updated opsorch-core to 0.0.4" but the actual change is to v0.4.0 (major version jump from v0.0.4)

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk - adds new functionality without breaking existing behavior
  • The changes are straightforward: dependency upgrade and backward-compatible feature addition. Error from permalink retrieval is silently ignored (URL will be empty string), which is acceptable since it doesn't break message sending. The major version jump in opsorch-core (v0.0.4 to v0.4.0) suggests potential breaking changes in the dependency, but the code compiles and integration tests remain valid.
  • go.mod should be verified that v0.4.0 is the correct version (commit message says v0.0.4)

Important Files Changed

Filename Overview
.gitignore Added .env.local to gitignore for local environment configuration
go.mod Bumped opsorch-core from v0.0.4 to v0.4.0 - major version jump
integ/messaging.go Added URL output to integration test output when available
messaging/slack_provider.go Added permalink retrieval to populate URL field in MessageResult

Sequence Diagram

sequenceDiagram
    participant Client as Client/Integration Test
    participant Provider as SlackProvider
    participant SlackAPI as Slack API
    
    Client->>Provider: Send(ctx, Message)
    Provider->>Provider: Convert blocks to Slack format
    Provider->>SlackAPI: PostMessageContext(channel, blocks)
    SlackAPI-->>Provider: channelID, timestamp
    Provider->>SlackAPI: GetPermalinkContext(channelID, timestamp)
    SlackAPI-->>Provider: permalink URL (or error)
    Note over Provider: Error silently ignored,<br/>URL will be empty if fails
    Provider->>Provider: Build MessageResult with URL
    Provider-->>Client: MessageResult{ID, Channel, SentAt, URL}
Loading

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

}

// Get permalink for the message
permalink, _ := p.client.GetPermalinkContext(ctx, &slack.PermalinkParameters{

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style: Error from GetPermalinkContext silently ignored with blank identifier.

If permalink retrieval is critical, consider logging the error:

Suggested change
permalink, _ := p.client.GetPermalinkContext(ctx, &slack.PermalinkParameters{
// Get permalink for the message
permalink, err := p.client.GetPermalinkContext(ctx, &slack.PermalinkParameters{
Channel: channelID,
Ts: timestamp,
})
if err != nil {
// Log but don't fail the send operation
}

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Prompt To Fix With AI
This is a comment left during a code review.
Path: messaging/slack_provider.go
Line: 91:91

Comment:
**style:** Error from `GetPermalinkContext` silently ignored with blank identifier.

If permalink retrieval is critical, consider logging the error:
```suggestion
	// Get permalink for the message
	permalink, err := p.client.GetPermalinkContext(ctx, &slack.PermalinkParameters{
		Channel: channelID,
		Ts:      timestamp,
	})
	if err != nil {
		// Log but don't fail the send operation
	}
```

<sub>Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!</sub>

How can I resolve this? If you propose a fix, please make it concise.

@yusufaytas
yusufaytas merged commit 9caf25a into main Jan 5, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant