Support custom properties on teams

[andrewstillv15]

Resolves #12820

Problem

We need to support custom properties for teams

Solution

Add custom property CRU operations for teams. Added a new service.GetProperty as the original GetProperty while following the Opslevel schema was misleading as it appeared to support teams.

Test code for your enjoyment:

func TeamPropertyTest(client *ol.Client) {
	fmt.Println("=== Testing custom properties on teams ===")

	// 1. Find a team to test with
	teams, err := client.ListTeams(nil)
	if err != nil {
		fmt.Printf("❌ Failed to list teams: %v\n", err)
		return
	}
	if len(teams.Nodes) == 0 {
		fmt.Println("❌ No teams found")
		return
	}
	team := teams.Nodes[0]
	fmt.Printf("Using team: %s (ID: %s)\n", team.Alias, team.Id)

	// 2. Create a property definition
	schema, err := ol.NewJSONSchema(`{"type":"string"}`)
	if err != nil {
		fmt.Printf("❌ Failed to create JSON schema: %v\n", err)
		return
	}
	def, err := client.CreateTeamPropertyDefinition(ol.TeamPropertyDefinitionInput{
		Alias:  "opslevel-go-team-test",
		Name:   "opslevel-go-team-test",
		Schema: *schema,
	})
	if err != nil {
		fmt.Printf("❌ Failed to create property definition: %v\n", err)
		return
	}
	fmt.Printf("✅ Created property definition: %s (ID: %s)\n", def.Name, def.Id)

	// 3. Assign the property to the team
	property, err := client.PropertyAssign(ol.PropertyInput{
		Owner:      ol.IdentifierInput{Id: &team.Id},
		Definition: ol.IdentifierInput{Id: &def.Id},
		OwnerType:  &ol.PropertyOwnerTypeEnumTeam,
		Value:      ol.JsonString(`"hello from opslevel-go"`),
	})
	if err != nil {
		fmt.Printf("❌ Failed to assign property to team: %v\n", err)
		if _, err := client.AssignTeamPropertyDefinitions(ol.TeamPropertyDefinitionsAssignInput{
			Properties: []ol.TeamPropertyDefinitionInput{},
		}); err != nil {
			fmt.Printf("⚠️  Failed to clear team property definitions: %v\n", err)
		} else {
			fmt.Println("✅ Cleared team property definitions")
		}
		return
	}
	fmt.Printf("✅ Assigned property to team, value: %s\n", *property.Value)

	// 4. Retrieve the property back
	retrieved, err := team.GetProperty(client, string(def.Id))
	if err != nil {
		fmt.Printf("❌ Failed to get property: %v\n", err)
		if _, err := client.AssignTeamPropertyDefinitions(ol.TeamPropertyDefinitionsAssignInput{
			Properties: []ol.TeamPropertyDefinitionInput{},
		}); err != nil {
			fmt.Printf("⚠️  Failed to clear team property definitions: %v\n", err)
		} else {
			fmt.Println("✅ Cleared team property definitions")
		}
		return
	}
	fmt.Printf("✅ Retrieved property, value: %s\n", *retrieved.Value)

	// 5. List properties on the team
	properties, err := team.GetProperties(client, nil)
	if err != nil {
		fmt.Printf("❌ Failed to list team properties: %v\n", err)
		if _, err := client.AssignTeamPropertyDefinitions(ol.TeamPropertyDefinitionsAssignInput{
			Properties: []ol.TeamPropertyDefinitionInput{},
		}); err != nil {
			fmt.Printf("⚠️  Failed to clear team property definitions: %v\n", err)
		} else {
			fmt.Println("✅ Cleared team property definitions")
		}
		return
	}
	found := false
	for _, p := range properties.Nodes {
		if p.Definition.Id == def.Id {
			found = true
			break
		}
	}
	if !found {
		fmt.Printf("❌ Property not found in team.GetProperties() results\n")
	} else {
		fmt.Printf("✅ Property found in team.GetProperties() (%d total properties on team)\n", len(properties.Nodes))
	}

	// 6. Unassign the property
	err = client.PropertyUnassign(string(team.Id), string(def.Id))
	if err != nil {
		fmt.Printf("❌ Failed to unassign property: %v\n", err)
	} else {
		fmt.Println("✅ Property unassigned from team")
	}

	// 7. Cleanup - clear all team property definitions
	if _, err := client.AssignTeamPropertyDefinitions(ol.TeamPropertyDefinitionsAssignInput{
		Properties: []ol.TeamPropertyDefinitionInput{},
	}); err != nil {
		fmt.Printf("⚠️  Failed to clear team property definitions: %v\n", err)
	} else {
		fmt.Println("✅ Cleared team property definitions")
	}

	fmt.Println("\n✅ Team property test complete")
}

Checklist

• I have run this code, and it appears to resolve the stated issue.
• This PR does not reduce total test coverage
• This PR has no user interface changes or has already received approval from product management to change the interface.
• Does this change require a Terraform schema change?
  • If so what is the ticket or PR #
• Make a changie entry that explains the customer facing outcome of this change

[derek-etherton-opslevel]

LGTM, just a bug with team.GetProperties TotalCount always returning 0 - it's also bugged on service.GetProperties if we could fix both

[derek-etherton-opslevel]

this is a small breaking change where like property.Owner.Aliases would work before, but now you'd have to do property.Owner.ServiceId.Aliases. I think it makes sense though, maybe just ensure we record it as a breaking change in changelog? I'm not 100% sure how we handle these historically.

[derek-etherton-opslevel]

looks like the way we're loading properties totalCount on services is wrong, and we cargo culted it here. This is just a recursive loop so totalCount is always 0 - I think we yoinked a ListX pattern by accident, which works a bit differently.

I think we can just set totalCount at the very end, like: service.Properties.TotalCount = len(service.Properties.Nodes)