Crash: Unexpectedly found nil while unwrapping an Optional value#790
Draft
jcmosc wants to merge 1 commit intoOpenSwiftUIProject:mainfrom
Draft
Crash: Unexpectedly found nil while unwrapping an Optional value#790jcmosc wants to merge 1 commit intoOpenSwiftUIProject:mainfrom
jcmosc wants to merge 1 commit intoOpenSwiftUIProject:mainfrom
Conversation
🤖 Augment PR SummarySummary: Adds a regression test reproducing a fatal optional-unwrapping crash when nesting variadic view roots. Changes:
Technical Notes: Tests run only under 🤖 Was this summary useful? React with 👍 or 👎 |
| } | ||
|
|
||
| @Test | ||
| func nestedMultiViewRoot() { |
There was a problem hiding this comment.
Since this PR adds only the repro test, if the underlying crash is still present this will abort the whole test run (fatal error) rather than reporting a normal test failure; is this intended to land only together with the fix or be marked as an expected failure until then?
Severity: medium
Other Locations
Tests/OpenSwiftUICoreTests/View/VariadicViewTests.swift:26
🤖 Was this useful? React with 👍 or 👎, or 🚀 if it prevented an incident/outage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This contains a test case that reproduces a crash when nesting multi root variadic views:
#791