elf bug fixes - #1697
Open
NickGuyver wants to merge 2 commits into
Open
Conversation
Using codex 5.6 sol, I prompted it to review the arm assembly and work backwards to find where the intention of the source code didn't match. Then I went through and validated the bugs via ghidra. After that, fixed and ran ghidra against each fix to verify that assembly was correct. macroposition on idle from passing index -1 to macrolist remove extra boardledenabled swap PSCLASSIC_MASK_START and PSCLASSIC_MASK_SELECT increase range on brake and gas for wheel xinput type off by one for keyboard host modifier out of range clamping for snowflake screensaver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using codex 5.6 sol, I prompted it to review the arm assembly and work backwards to find where the intention of the source code didn't match. Then I went through and validated the bugs via ghidra. After that, fixed and ran ghidra against each fix to verify that assembly was correct.
macroposition on idle from passing index -1 to macrolist
remove extra boardledenabled
swap PSCLASSIC_MASK_START and PSCLASSIC_MASK_SELECT
increase range on brake and gas for wheel xinput type
off by one for keyboard host modifier
out of range clamping for snowflake screensaver