Skip to content

Feat: Replace code for iframe on proposals show page with external module#986

Merged
moustachu merged 9 commits into
developfrom
feat/module-iframe-on-proposals
May 23, 2026
Merged

Feat: Replace code for iframe on proposals show page with external module#986
moustachu merged 9 commits into
developfrom
feat/module-iframe-on-proposals

Conversation

@moustachu

Copy link
Copy Markdown
Member

🎩 Description

Replace code for iframe on proposals show page (PR #960) with external module

  • Add interpolation to include the proposals title / body in the iframe URL

📌 Related Issues

Removed chrome_version input and related installation steps, replacing them with browser-actions/setup-chrome.
Stef-Rousset
Stef-Rousset previously approved these changes May 19, 2026

@Stef-Rousset Stef-Rousset left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@moustachu moustachu dismissed stale reviews from Stef-Rousset and BarbaraOliveira13 via 1eeafa6 May 22, 2026 22:30
@moustachu moustachu merged commit 99f153f into develop May 23, 2026
10 checks passed
@moustachu moustachu deleted the feat/module-iframe-on-proposals branch May 23, 2026 21:36
moustachu added a commit that referenced this pull request May 27, 2026
…dule (#986)

* feat: revert code for iframe on proposals show page

* feat: add module-mutilpod-iframe

* fix: Refactor Chrome setup in test_app workflow

Removed chrome_version input and related installation steps, replacing them with browser-actions/setup-chrome.

* Add iframe settings to i18n-tasks configuration

* Add French translations for category and scope requirements

* fix: missing translations keys
@moustachu moustachu restored the feat/module-iframe-on-proposals branch June 11, 2026 12:30
@moustachu moustachu deleted the feat/module-iframe-on-proposals branch June 11, 2026 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants