Release: BIDS widget CORS preview origins (v0.8.5)#320
Merged
Conversation
The post-release sync failed on every release (through v0.8.4) at the checkout step: under the workflow_run trigger, actions/checkout's wildcard fetch (+refs/heads/*) intermittently advertised only main, so ref: develop raised 'a branch or tag with the name develop could not be found'. Check out main (always advertised) and fetch develop by explicit name, which requests the ref directly and is reliable.
Allow the BIDS assistant widget to load on the ReadTheDocs PR preview builds for bids-standard/bids-specification#2442 and bids-standard/bids-website#847 so reviewers can try the widget before merge. These two origins are temporary and should be removed once both PRs merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Promotes
developtomain(production). Headline change is the temporary BIDS CORS origins so reviewers can try the assistant widget on the ReadTheDocs PR previews; merging this tomaindeploys it to the production backend the previews call.Included
Add BIDS RTD PR-preview origins to CORS (temporary) (Add BIDS RTD PR-preview origins to CORS (temporary) #319) — allows the widget on:
These two origins are commented as temporary and should be removed once the upstream PRs merge.
CI:
sync-developchecks outdevelopby explicit ref (fix(ci): repair recurring sync-develop checkout failure #318)Routine dev version bumps (0.8.5.dev0/dev1)
Why merge to main
CORS is assembled at FastAPI startup, and the RTD preview hosts (
*.org.readthedocs.build) resolve to the production OSA worker. So the preview pages only work once this reaches prod and theosacontainer is redeployed.Notes
.devsuffix and tag the release on merge per the standard flow; no manual version bump here.